i18n:target support

[Jean-François Doyon]

I've patched the trunk to enable i18n:target support in the page template implementation. Find the output of "svn diff" attached.

The tests all pass.

I haven't tested this myself, since I'm actually not a Zope 3 user. I use Zope 2 and need the functionality, which I currently enable through a monkey patch.

Let me know if I missed anything, my first time providing a patch in this fashion.

[Philipp von Weitershausen (philikon)]

I'm a bit skeptical because we now make engines take another keyword argument in their translate() method. Not sure if this is a good idea, it might break backward-compatibility.

Either way, this patch should come with an accompanying test that demonstrates i18n:target now actually works. "I've tested it myself" isn't enough because the rest of can't repeat it. Furthermore, we can't repeat it in an automated fashion. That's why we require unit tests.

There are plenty of existing tests that you can probably just enhance with one for i18n:target.

[Jean-François Doyon (jdoyon)]

Re: zope.tal.interfaces.ITALExpressionEngine ...

I can't see any other way to do it? The code mentions "zope.i18n.interfaces.ITranslationDomain.translate" for some reason ... that interface does have a target_language parameter.

It seems the interface was just short a necessary parameter from the beginning, for some reason? Having both interfaces with the same signature seems sensible.

As for tests ... I know, I've just never worked with that whole setup, I'll come up with something :) My first attempt ended in failure.

[Christian Theune (ctheune)]

This is a feature.

[Colin Watson (cjwatson)]

The zope.tal project on Launchpad has been archived at the request of the Zope developers (see https://answers.launchpad.net/launchpad/+question/683589 and https://answers.launchpad.net/launchpad/+question/685285). If this bug is still relevant, please refile it at https://github.com/zopefoundation/zope.tal.