Implement history_preview for ux2

Bug #983874 reported by Paul Everitt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Medium
JimPGlenn

Bug Description

We're using a different confirmation popup for ux2, one from Twitter Bootstrap instead of jQuery UI. Carlos wired one up for Deactivate User. Feel free to assign this to him, or ask him if you want to give it a try.

Tags: tested r3.86 ux2
Revision history for this message
Chris Rossi (chris-archimedeanco) wrote :

Done. Assigning to Blaise in case he wants to make any style tweaks.

Changed in karl3:
status: New → In Progress
assignee: Chris Rossi (chris-archimedeanco) → blaflamme (blaise-laflamme)
assignee: blaflamme (blaise-laflamme) → Chris Rossi (chris-archimedeanco)
Revision history for this message
Chris Rossi (chris-archimedeanco) wrote :

Oops, wrong ticket. I need this one back.

Revision history for this message
Chris Rossi (chris-archimedeanco) wrote :

Basically done but there are a couple of style issues that seem to be related to styles that exist in base bootstrap having been overridden or removed:

'div.modal' is not hidden, by default. As a quick work around I've resorted to hiding the modal via js in a document ready event handler.

'a.close' should float to the right and the mouse cursor should change as for a regular link.

Changed in karl3:
assignee: Chris Rossi (chris-archimedeanco) → blaflamme (blaise-laflamme)
Revision history for this message
blaflamme (blaise-laflamme) wrote :

updated to latest bootstrap css, fixed link hover cursor, close box on right side and title flows ok. Don't forget to add «hide» class to your modal, this is how bootstrap hides modal.

Changed in karl3:
assignee: blaflamme (blaise-laflamme) → JimPGlenn (jpglenn09)
status: In Progress → Fix Committed
Revision history for this message
Paul Everitt (paul-agendaless) wrote : Re: [Bug 983874] Implement history_preview for ux2

Looks good.

On Apr 22, 2012, at 2:38 PM, blaflamme wrote:

> updated to latest bootstrap css, fixed link hover cursor, close box on
> right side and title flows ok. Don't forget to add «hide» class to your
> modal, this is how bootstrap hides modal.
>
> ** Changed in: karl3
> Status: In Progress => Fix Committed
>
> ** Changed in: karl3
> Assignee: blaflamme (blaise-laflamme) => JimPGlenn (jpglenn09)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/983874
>
> Title:
> Implement history_preview for ux2
>
> Status in KARL3:
> Fix Committed
>
> Bug description:
> We're using a different confirmation popup for ux2, one from Twitter
> Bootstrap instead of jQuery UI. Carlos wired one up for Deactivate
> User. Feel free to assign this to him, or ask him if you want to give
> it a try.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/983874/+subscriptions

Revision history for this message
JimPGlenn (jpglenn09) wrote :

tested...got a question on dates being yyyymmdd is that what you wanted.? Also changing from european to us or vice versa has no effect on history dates.

tags: added: tested
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

We're just implementing what's on ux1/production. If it doesn't match there, it's a bug.

--Paul

On Apr 24, 2012, at 10:56 AM, JimPGlenn wrote:

> tested...got a question on dates being yyyymmdd is that what you
> wanted.? Also changing from european to us or vice versa has no effect
> on history dates.
>
> ** Tags added: tested
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/983874
>
> Title:
> Implement history_preview for ux2
>
> Status in KARL3:
> Fix Committed
>
> Bug description:
> We're using a different confirmation popup for ux2, one from Twitter
> Bootstrap instead of jQuery UI. Carlos wired one up for Deactivate
> User. Feel free to assign this to him, or ask him if you want to give
> it a try.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/983874/+subscriptions

Revision history for this message
JimPGlenn (jpglenn09) wrote :

Ux1 and UX2 match....looks good

Revision history for this message
JimPGlenn (jpglenn09) wrote :

fixed

Changed in karl3:
status: Fix Committed → Fix Released
JimPGlenn (jpglenn09)
tags: added: r3.86
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.