New packages openerp-core and openerp-desktop

[Yolanda Robla]

From inside the EA team, we developed some new packages for OpenERP 6.1 (openerp-core and openerp-desktop).
openerp-core provides the source code from OpenERP, places files in the right places and starts the OpenERP daemon.
openerp-desktop provides integration with postgresql, and updates OpenERP configuration, to have a working OpenERP server/web client.
Our idea is to have openerp-core as a package for more professional syadmins, or to be integrated with juju (a juju charm is also in progress). And openerp-desktop can be the package that a normal users downloads and install, having a ready-to-use OpenERP.

Code for the packages is here:

https://code.launchpad.net/~openerp-community/openerp-tools/yolanda.robla-openerp-core
https://code.launchpad.net/~openerp-community/openerp-tools/yolanda.robla-openerp-desktop

[Stefano Rivera (stefanor)]

At this point, adding new packages is still doable, but it'll need an archive admin to volunteer to review it. As it isn't a sync from Debian, a willing archive admin may be hard to find.

[Scott Kitterman (kitterman)]

If it can be synced from Debian today, I'm OK with it.

[Iain Lane (laney)]

Approved if you

  - can get this done by next Thursday (19th April)
  - find an archive admin willing to do the NEW review /before/ uploading

I think you'll probably have trouble finding a sponsor and archive admin to do review of a NEW package this late in the cycle, so perhaps you could consider backporting after Q-series opens (backports are now enabled by default so this will have the same effect for users).

[Yolanda Robla (yolanda.robla)]

How can i find a sponsor? What steps do i need to follow?
If not, backporting will be ok for us.

[Iain Lane (laney)]

The sponsors are subscribed so somebody might take a look. You could also ask on IRC. But like I said, it's close to releae so people are pretty busy with bug fixing.

Is there any reason you couldn't try to get this into Debian and then sync into Ubuntu for Q? That is the usual way of doing things.

[Daniel Holbach (dholbach)]

Here a quick review of things I found:

OPENERP-CORE
 - the version of the package should be <upstreamversion>-<debian/ubuntu revision>,
   it is only OK to have on '-' in the complete version string
 - '0' is not allowed as debian/ubuntu revision either, better make it '0ubuntu1' instead
 - debian/watch file links exclusively to 6.1-1 - it won't find a 6.1-2
 - the Section for the binary package is not necessary
 - minor: the patch in debian/patches might benefit from a description
   (http://dep.debian.net/deps/dep3/)
 - there's a file called .apidoc in /usr/openerp (not sure if that's intentional)
 - minor: these license files can be removed:
   usr/share/openerp/addons/base_tools/LICENSE
   usr/share/openerp/addons/web_calendar/static/lib/dhtmlxScheduler/license.txt
   usr/share/openerp/addons/web_graph/static/lib/dhtmlxGraph/codebase/thirdparty/excanvas/COPYING
   usr/share/openerp/addons/web_livechat/LICENSE
   usr/share/openerp/addons/web_uservoice/LICENSE
   (just make sure you integrate them in debian/copyright)
 - minor: these files can be removed:
   usr/share/openerp/addons/plugin_outlook/static/openerp-outlook-plugin/OpenERPOutlookPlugin.sln
   usr/share/openerp/addons/web/static/lib/py.parse/.hg_archival.txt
 - the following bits and pieces would be good to 1) remove, 2) depend on the package in the archive,
   3) symlink to the files in question if necessary:
   usr/share/openerp/addons/wiki/web/widgets/rss/feedparser.py
   usr/share/openerp/addons/web/static/lib/underscore/underscore.js
   usr/share/openerp/addons/web/static/lib/jquery.tipsy/jquery.tipsy.js
   usr/share/openerp/addons/web/static/lib/jquery.form/jquery.form.js
 - etc/init.d/openerp-core does not provide itself (none of the provided facilities
   match the name of the init script)
 - etc/init.d/openerp-core does not implement 'status'
 - usr/share/openerp/addons/plugin_thunderbird/static/thunderbird_plugin/chrome/openerp_plugin.jar
   contains no code

OPENERP-DESKTOP
 - desktop does not have a debian/watch file
 - http://open-object.debian-maintainers.org/ does not seem to exist
 - where does the source tarball come from?

[Dimitri John Ledkov (xnox)]

Dear all,

I have been working on openerp a lot with my previous employer, and have deep knowledge from 5.0 all the way to current trunk (6.2/7.0).

I currently have the ITP for OpenERP in Debian and some working packaging for 6.0 (as that was a priority for my previous employer). The latest state of this packaging effort is in the debian-python-apps team svn repository.

I am happy to review this packaging work, merge it with mine & upload it into Debian + sync to ubuntu-q, if it is of suitable quality.

Regards,

Dmitrijs.

[Daniel Holbach (dholbach)]

Dmitrijs: when do you think you can make a bit of time to have a look at the differences between the two openerp packaging approaches and report back? It'd be nice to get it into Q before Feature Freeze, etc.

[Yolanda Robla (yolanda.robla)]

OPENERP-CORE

Daniel, I have corrected some of the bugs you reported, but i have some questions about others (i'm a bit newbie on it, perhaps are very obvious things but i cannot get it):
- the version of the package should be <upstreamversion>-<debian/ubuntu revision>,
   it is only OK to have on '-' in the complete version string -> what do you mean, modify the changelog, and perhaps put something like openerp-core (6.1-ubuntu1) ? If going to Debian should be 6.1-debian1?
- '0' is not allowed as debian/ubuntu revision either, better make it '0ubuntu1' instead -> related to first question
- debian/watch file links exclusively to 6.1-1 - it won't find a 6.1-2 -> i've modified the watch file to match all 6.1.x files
- the Section for the binary package is not necessary -> where is that? how can i remove it?
- minor: the patch in debian/patches might benefit from a description ->done
- there's a file called .apidoc in /usr/openerp (not sure if that's intentional) -> removed it
- minor: these license files can be removed: -> removed that files and added licenses to debian/copyright
- minor: these files can be removed: -> remove all extra files
 - the following bits and pieces would be good to 1) remove, 2) depend on the package in the archive, -> what do you mean?
- symlink to the files in question if necessary: -> what do you mean?
 - etc/init.d/openerp-core does not provide itself (none of the provided facilities
   match the name of the init script) -> that is a question i had. The package is called openerp-core, but the init script is openerp-server, is how the service, the daemon, etc... is called. What can we do about it? Can't we name a package differently from the main service it provides?
- etc/init.d/openerp-core does not implement 'status' -> it's provided by OpenERP, should i modify it to add 'status' ?
- usr/share/openerp/addons/plugin_thunderbird/static/thunderbird_plugin/chrome/openerp_plugin.jar
   contains no code -> it's provided by OpenERP, should i remove the file?

OPENERP-DESKTOP
 - desktop does not have a debian/watch file -> that's because no code is needed, this package just adds dependency on postgres, and configure database
- http://open-object.debian-maintainers.org/ does not seem to exist -> i can ask OpenERP about right location
- where does the source tarball come from? -> this package doesn't need a source tarball

[Daniel Holbach (dholbach)]

Dmitrijs: did you have a chance to look into this?

[Dimitri John Ledkov (ex-credativ) (dle-credativ)]

Daniel: Sorry, not yet. I have been busy with UDS/specs.

[Daniel Holbach (dholbach)]

Here a few comments until Dmitrijs finds some time to look over this:

 - version: maybe we could call it 6.1+1-0ubuntu1 to indicate that it's the first revision
   of upstream's '-1 build' of 6.1 in Ubuntu?
 - Section: fixed in a merge proposal I sent (also fixed some tab-vs.-spaces issue in
   debian/rules)
 - bundled code: the following code is already shipped by other packages in the archive
   and it'd be good to use them instead, because we ship the code in well-maintained
   packages already, so if there's a security vulnerability we only have to fix it in one
   place. So it'd be good to remove the code in question, replace it with a symlink to
   the packaged version and depend on the package in question.
   http://bazaar.launchpad.net/~ubuntu-packaging-guide-team/ubuntu-packaging-guide/trunk/revision/91
   might serve as an example.
   usr/share/openerp/addons/wiki/web/widgets/rss/feedparser.py
   usr/share/openerp/addons/web/static/lib/underscore/underscore.js
   usr/share/openerp/addons/web/static/lib/jquery.tipsy/jquery.tipsy.js
   usr/share/openerp/addons/web/static/lib/jquery.form/jquery.form.js
 - I don't have a good answer for the init script question. Maybe the server team
   can help?
 - If the thunderbird plugin is of no use, I'd say remove it.
 - openerp-desktop: how do I build the package?

[Yolanda Robla (yolanda.robla)]

Ok, i take a look at your comments.
About openerp-desktop, i build it using dpkg:

dpkg-buildpackage -S -rfakeroot -k$GPGKEY

Is that ok?

[Daniel Holbach (dholbach)]

If I try that, it complains that there is no -desktop tarball available, so the resulting binary package is empty too.

daniel@daydream:~/yolanda.robla-openerp-desktop$ debuild -S
This package has a Debian revision number but there does not seem to be
an appropriate original tar file or .orig directory in the parent directory;
(expected one of openerp-desktop_6.1-1.orig.tar.gz, openerp-desktop_6.1-1.orig.tar.bz2,
openerp-desktop_6.1-1.orig.tar.lzma, openerp-desktop_6.1-1.orig.tar.xz or yolanda.robla-openerp-desktop.orig)
continue anyway? (y/n)
....

[Yolanda Robla (yolanda.robla)]

I'm not having any problem with dpkg-buildpackage, but i don't really know if that's the correct way or not. The thing is that openerp-desktop doesn't have any source code, it depends on openerp-core and postgres, but isn't providing any original source code. Is there something i must specify, or a different way of building it?

[Daniel Holbach (dholbach)]

Ok. I put up a merge proposal to address this.

[Daniel Holbach (dholbach)]

openerp-core seems to fail to build for me now:

find debian/openerp-core \( \
  -name '*.html' -o -name 'input_complete' -o -name '*.dat' \
  -o -name '*.js' -o -name '*.png' -o -name '*.po' \
  -o -name '*.css' -o -name '*.md' -o -name '*.csv' \
  -o -name '*.yml' -o -name '*.v11' -o -name '*.ttf' \) \
     | xargs -r chmod a-x
chmod: cannot operate on dangling symlink `debian/openerp-core/usr/share/openerp/addons/web/static/lib/jquery.form/jquery.form.js'
chmod: cannot operate on dangling symlink `debian/openerp-core/usr/share/openerp/addons/web/static/lib/underscore/underscore.js'
chmod: cannot operate on dangling symlink `debian/openerp-core/usr/share/openerp/addons/web/static/lib/jquery.tipsy/jquery.tipsy.js'
make[1]: *** [override_dh_fixperms] Error 123

[Andrew Starr-Bochicchio (andrewsomething)]

Un-subscribing sponsors for now as this doesn't seem to be ready yet. Feel free to resubscribe when needed. Thanks!

[Dimitri John Ledkov (xnox)]

Me and Yolanda, were working together a lot on this package lately. It is almost ready, apart from now we require a few javascript dependencies sorted in quantal and in precise. Debian looks ok. Hopefully we will upload soon.

See https://bugs.launchpad.net/bugs/+bugs?field.tag=affects-openerp-itp for complete todo list.

[Yolanda Robla (yolanda.robla)]

New branch is on: bzr+ssh://bazaar.launchpad.net/~openerp-community/openerp-tools/yolanda.robla-openerp6.1/

[Chris Halls (halls)]

Hi there, thanks for packaging Openerp.

I see that the packages in the repository are now called openerp-core and openerp-full. I don't think that -full really describes that this is a ready configured server. Other packages in Debian with the name -full do not provide this sort of service.

Looking through other package names, I see a fair amount of packages using the terms -core, and some using -minimal, for the reduced set of functionality. -server seems to be a good choice, and uses the existing package name.

So can I suggest you use

openerp-server - for the full, configured functionality
openerp-core - for the minimal code

It'll also make it slightly easier for the admin to understand what's happening during upgrades, and ensure they do not find the postgres dependencies are auto-uninstalled during an upgrade.

[Dimitri John Ledkov (xnox)]

On 21/06/12 13:37, Chris Halls (credativ) wrote:
> Hi there, thanks for packaging Openerp.
>
> I see that the packages in the repository are now called openerp-core
> and openerp-full. I don't think that -full really describes that this is
> a ready configured server. Other packages in Debian with the name -full
> do not provide this sort of service.
>
> Looking through other package names, I see a fair amount of packages
> using the terms -core, and some using -minimal, for the reduced set of
> functionality. -server seems to be a good choice, and uses the existing
> package name.
>
> So can I suggest you use
>
> openerp-server - for the full, configured functionality
> openerp-core - for the minimal code
>
> It'll also make it slightly easier for the admin to understand what's
> happening during upgrades, and ensure they do not find the postgres
> dependencies are auto-uninstalled during an upgrade.
>

True, but openerp-server was already used for openerp-server 5 in Debian
and Ubuntu and same name is still in use by the deb packages published
by upstream for various versions.

The legacy packages are incompatible with these new packages. I am
inclined to even add breaks: openerp-server.

For these reasons, -full was chosen, inline with a few other packages
which use -full for extra functionality. In this case, extra
functionality no extra setup needed.

--
Regards,
Dmitrijs.