EC2 terminate allows partial terminations

[Joshua Harlow]

When using ec2 it seems like all the instance ids that are given should either be terminated or none should be terminated? Currently it looks like the EC2 terminate operation can partially succeed, then throw an exception (thus signifying failure when actually some instances were terminated).

See: https://github.com/openstack/nova/blob/master/nova/api/ec2/cloud.py#L1318

You will notice that the instance ids are validated inside the loop, instead of beforehand, thus if instance ids 1, 2, 3 are passed in, 3 could be invalid, but 1 and 2 would have been terminated already, but an exception would be thrown for #3, thus sending a error back to the user, when really 2 instances were terminated.

That seems bad. Possible verify before u terminate and report partial success....

[Joshua Harlow (harlowja)]

This also seems valid for reboot instances, stop instances, ......

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/12747

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/12747
Committed: http://github.com/openstack/nova/commit/c2501d81b581536ae83793ac3d9879899f21dc1d
Submitter: Jenkins
Branch: master

commit c2501d81b581536ae83793ac3d9879899f21dc1d
Author: Joe Gordon <email address hidden>
Date: Tue Sep 11 00:22:55 2012 +0000

    Prevent Partial terminations in EC2

    When passing in a valid and an invalid EC2 id, the API should not partially
    execute the command, and instead just return an error.

    Fix bug 979336

    Also prevents partial:
    * starts
    * stops
    * reboots

    Change-Id: I28fb4f34aadfb7af14774db983d44584e61c5414