CVS "version" protocol request hits an assertion error and quits

[James Henstridge]

Binary package hint: cvs

The following tests were done with the feisty version of CVS (1:1.12.13-5build1)

From the cvsclient info pages, describing the version request:

`version \n'
     Response expected: yes. Request that the server transmit its
     version message. The `Root' request need not have been previously
     sent.

However if I try to run the "version" request without issuing a "Root" request, things fail:

    $ cvs server
    version
    cvs: server.c:587: isProxyServer: Assertion `current_parsed_root' failed.
    E cvs [server aborted]: received abort signal

If I issue a Root request for a non-existant root, I get an error:

    $ cvs server
    Root /not/a/root
    version
    E Cannot access /not/a/root/CVSROOT
    error No such file or directory

However, I can get the version number if I add a noop between the two requests:

    $ cvs server
    Root /not/a/root
    noop
    E Cannot access /not/a/root/CVSROOT
    error No such file or directory
    version
    M Concurrent Versions System (CVS) 1.12.13 (client/server)
    ok

Issuing a "version" request without "Root" worked correctly in dapper, so this is a regression.

[Daniel T Chen (crimsun)]

Is this symptom still reproducible in 8.10 alpha/beta?

[James Henstridge (jamesh)]

I don't currently have an 8.10 install to test on, but it does occur with 8.04:

    $ cvs server
    version
    cvs: server.c:587: isProxyServer: Assertion `current_parsed_root' failed.
    E cvs [server aborted]: received abort signal

If you have 8.10 installed, it should take 5 seconds to test using the steps given in the bug report. Given that the upstream version hasn't changed since the bug was filed, it seems likely that the problem still exists.

[James Henstridge (jamesh)]

Just tested on Intrepid (version 1:1.12.13-11), and the same error occurs.

[Dimitrios Symeonidis (azimout)]

confirmed on jaunty (1:1.12.13-12ubuntu1)

[Thorsten Glaser (mirabilos)]

will be fixed with the next Debian import, after I upload the new cvs package

[Launchpad Janitor (janitor)]

This bug was fixed in the package cvs - 2:1.12.13+real-5

---------------
cvs (2:1.12.13+real-5) unstable; urgency=low

  * Drop PAM entirely, it was specific to Debian anyway
  * Add cvs-switchroot, from src/scripts/mnt-cvsroot (Closes: #41685)
  * Drop some old and irrelevant changelogs from the binary package
  * Update from MirPorts 1.12.13-11 = MirOS BSD 0AAE.2
  * Revert most of 65_login_cvspass_message and just be silent if the
    pserver client password file doesn't exist and create it silently
    if needed (Closes: #524146)
  * Honour noexec flag in 'cvs -n init' (Closes: #151982)
  * Sync modules option list with cederqvist (Closes: #226888)
  * Apply patch for assert on negated version numbers on diff
    (Closes: #297551)
    From: Peter Moulder <email address hidden>
  * Change cvs add dir message (Closes: #294094)
  * Accept port when using extssh connection method (Closes: #151882)
  * Write a new command for direct ,v file download (Closes: #421119)
  * Drop broken libbsd.fd.o headers and shut up gcc 4.6 warnings
  * Fix piuparts breakage: ignore delgroup non-existence on purge
  * Deliver a NEWS.Debian (Closes: #626106)
  * d/README.source: Update, call to automake is now also needed

cvs (2:1.12.13+real-4) unstable; urgency=low

  * Renamed .orig.tar.gz due to archive pathname conflict
  * d/README.source: Document patch location (VCS-CVS, VCS-Browser alike)
  * New build from MirPorts 1.12.13-10 = MirOS BSD 0AAE.1
    - Contains changes from cvs (1:1.12.13-12ubuntu1):
      + Apply fix from Kees Cook to avoid %n in writable memory (LP: #296453)
    - Other BTS relevant changes:
      + Allow CVSROOT-less “version” (LP: #97683) and “cvs version”
      + Update loginfo documentation, ‘%{t}’ is indeed gone (Closes: #329151)
      + Lower syslog level from emergency (Closes: #563856)
      + Fix awk substr start argument, thanks John Hughes (Closes: #518600)
      + Rename nodes with colons in them (Closes: #113809)
      + Fix typo (Closes: #464137)
      + Document missing rcs2log(1) options (Closes: #306354) and fix dashes
  * Upload new package to Debian unstable (Closes: #306432)
    (Closes: #458864) (Closes: #464134) (Closes: #479752)
    (Closes: #576035) (Closes: #614700) (Closes: #617578)
    - Drop PAM (Closes: #340984) (Closes: #393436)
    - No longer installs repositories (Closes: #168300)
      (Closes: #408117) (Closes: #482301) (Closes: #499790)
      (Closes: #511643) (Closes: #607297)
    - Deprecate pserver (Closes: #343169) (Closes: #495938)
    - Drop Origin and Bugs headers again (upload to Debian proper)
      and old (pre-Debian upload) private repo changelog entries
    - Thank you, Steve, for handing over package maintainership!
  * Clarify package description (LP: #377411)
  * Build with Kerberos V support (Closes: #60800) (LP: #157760)
  * Recommends: openssh-client; Suggests: rcs
 -- Thorsten Glaser <email address hidden> Tue, 14 Jun 2011 10:45:16 +0000