horizon.js is broken in safari

[Anthony Young]

It looks like all functionality provided by horizon.js may be broken in Safari (5.05).

Steps to reproduce:

> Launch an instance
> Click instance details
> Click the log tab

Expected:

Log

Actual:

No activity: http://stsh.me/1W5

It looks like in safari the method 'delete' on line 62 of horizon.js is interpreted as the delete operator, causing a syntax error.

[Anthony Young (sleepsonthefloor)]

This bug may only exist in OSX 10.6 - I had somebody on Lion try to repro, and everything seemed fine.

[Devin Carlen (devcamcar)]

Can we get a clear update on what OSX version this affects? I don't have a 10.6 install to test with ...

[John Postlethwait (john-postlethwait)]

Anthony – can you let us know which version of OSX this actually affects? Lion is all I have and, as you said, I do not see this...

[Anthony Young (sleepsonthefloor)]

After upgrading safari, I can no longer reproduce this issue. It is possible that there was a parser issue in 5.05 that has been fixed. As I recall, the keyword 'delete' was being used as an object property: https://developer.mozilla.org/en/JavaScript/Reference/Reserved_Words

[Ke Wu (ke-wu)]

Can't reproduce it with Snow Leopard and Safari 5.0.5.

Will change the reverse word "delete" to "remove"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/7632

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/7632
Committed: http://github.com/openstack/horizon/commit/524d7ff8b10d4e90e9ee089d574cefcbb5e50609
Submitter: Jenkins
Branch: master

commit 524d7ff8b10d4e90e9ee089d574cefcbb5e50609
Author: Ke Wu <email address hidden>
Date: Mon May 21 10:25:45 2012 -0700

    bug #974599, rename the cookie 'delete' function to 'remove' to avoid reserve word usage

    Change-Id: I1568e4c859d3f529b0efb9d945cc30f6ae3e24d1