ImportError handling in override mechanism is broken

Bug #973836 reported by Gabriel Hurley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Gabriel Hurley
Essex
Fix Released
Medium
Gabriel Hurley

Bug Description

If you do something in your override file that causes an import error you'll get a very useless traceback about the fact that str objects don't have a __name__ property. This masks the real exception and makes debugging more difficult.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/6257

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/6257
Committed: http://github.com/openstack/horizon/commit/a4679bc7b5ad66e5e45cc17fa73df1eb00cf056b
Submitter: Jenkins
Branch: master

commit a4679bc7b5ad66e5e45cc17fa73df1eb00cf056b
Author: Gabriel Hurley <email address hidden>
Date: Wed Apr 4 16:16:53 2012 -0700

    Corrects the ImportError handling for the override mechanism.

    Fixes bug 973836.

    Change-Id: Ide849ca230d1e07c7242268d32f06600e09c6746

Changed in horizon:
status: In Progress → Fix Committed
description: updated
Devin Carlen (devcamcar)
tags: added: essex-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/essex)

Fix proposed to branch: stable/essex
Review: https://review.openstack.org/6936

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/essex)

Reviewed: https://review.openstack.org/6936
Committed: http://github.com/openstack/horizon/commit/77371f33db12cbcca4844a6b8a80aa24b049020f
Submitter: Jenkins
Branch: stable/essex

commit 77371f33db12cbcca4844a6b8a80aa24b049020f
Author: Gabriel Hurley <email address hidden>
Date: Wed Apr 4 16:16:53 2012 -0700

    Corrects the ImportError handling for the override mechanism.

    Fixes bug 973836.

    Change-Id: Ide849ca230d1e07c7242268d32f06600e09c6746

tags: added: in-stable-essex
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: folsom-1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.