[UIFe] Bluebird rebased against Greybird for Gtk3.4

Bug #969252 reported by Simon Steinbeiß
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
shimmer-themes (Ubuntu)
Fix Released
Undecided
Lionel Le Folgoc

Bug Description

I recently got around to rebasing Bluebird against Greybird to make it work with Gtk3.4.

It took me a lot of time the last few months to iron out all the glitches introduced with the newer versions of Unico and Gtk3, so rebasing Bluebird (most of its widgets look very similar to Greybird) seemed like the best way to get Bluebird's Gtk3 theme ready for Precise.

Since Greybird Gtk3 has been thoroughly tested for Precise and I only changed a few widgets to make the theme look more like Bluebird, this is – even though the amount of lines changed is rather high (==rebase!) – a safe upload and should be considered for UserInterfaceFreeze exception.

Here's a link to the respective commit:
https://github.com/shimmerproject/Bluebird/commit/eb3ce602cdc20114ecc4c7457ebf01d750fbbb6d

(As you can see in the commit-log in github, I mostly rebased Bluebird versus Greybird lately ;) )

Pasi Lallinaho (knome)
summary: - Bluebird rebased against Greybird for Gtk3.4
+ [UIFe] Bluebird rebased against Greybird for Gtk3.4
Revision history for this message
Adam Conrad (adconrad) wrote :

The rebasing sounds like a sane and reasonable thing to do. Can we see a diff between greybird and bluebird, instead of between old bluebird and new bluebird? The latter is, as you point out, pretty much unreadable and useless.

Revision history for this message
Pasi Lallinaho (knome) wrote :

Adding a diff between the Greybird and Bluedird themes (diff -U 0, which is hopefully the most helpful) in changed files.

Revision history for this message
Adam Conrad (adconrad) wrote :

A little noisy because of all the s/1/1px/ (why are they different in that respect?), but looks fine. Upload whenever.

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

They are different because the diff was seemingly made between Greybird/master and Bluebird/master, whereas it should've been made between Greybird/gtk3.3 and Bluebird/master.
Sorry for the messy branches...

Revision history for this message
Lionel Le Folgoc (mrpouit) wrote :

Indeed, the diff is actually smaller when you take the correct greybird branch.

Changed in shimmer-themes (Ubuntu):
assignee: nobody → Lionel Le Folgoc (mrpouit)
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package shimmer-themes - 1.3.0-0ubuntu1

---------------
shimmer-themes (1.3.0-0ubuntu1) precise; urgency=low

  * Update greybird to the v0.7.1 tag (bugfix).
  * Update bluebird from git master (gtk+3 theme rebased against greybird to
    benefit from all bugfixes, lp: #969252).
 -- Lionel Le Folgoc <email address hidden> Fri, 30 Mar 2012 22:37:30 +0200

Changed in shimmer-themes (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.