Bad calls to get_string upload csv for duplicate remote usernames
Bug #968697 reported by
Richard Mansfield
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Low
|
Richard Mansfield |
Bug Description
When uploading users from a csv file, the remote usernames given in the file are checked for duplicates. When a duplicate is found, get_string is called to generate the error message using the string key 'uploadcsverror
tags: | added: csvupload |
Changed in mahara: | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
Reviewed: https:/ /reviews. mahara. org/1106 gitorious. org/mahara/ mahara/ commit/ 96cd77d432c908c 9be0ec8b571f338 b08f3a70c7
Committed: http://
Submitter: Francois Marier (<email address hidden>)
Branch: 1.5_STABLE
commit 96cd77d432c908c 9be0ec8b571f338 b08f3a70c7
Author: Richard Mansfield <email address hidden>
Date: Wed Mar 21 14:26:25 2012 +1300
Fix get_string calls for duplicate remote username message (bug #968697)
When uploading users from a csv file, the remote usernames given in remoteusertaken ', but in two of three instances, it
the file are checked for duplicates. When a duplicate is found,
get_string is called to generate the error message using the string
key 'uploadcsverror
is called with too few arguments to sprintf. Sometimes this results
in no error being reported to the user at all.
The error is fixed here by creating a new string without the second
argument for the first call, and by passing the additional argument in
the second call.
Change-Id: Iff93385dee2063 94c74b1d6b1ad94 84e90026dd4
Signed-off-by: Richard Mansfield <email address hidden>