Extension does not support moving tabs between windows (activity tracking degenerates)
Bug #967604 reported by
Robert Carr
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
WebApps: unity-firefox-extension |
Fix Released
|
Medium
|
Maxim Ermilov | ||
unity-firefox-extension (Ubuntu) |
Fix Released
|
Medium
|
Unassigned |
Bug Description
[IMPACT]
Moving a tab between windows will fail to update the XID of the interest breaking the tracking/BAMF integration
[TESTCASE]
1. open firefox window with 2 tabs (gmail, any other)
2. open new firefox window
3. move gmail's tab to new window
expected result:
gmail's icon stays in launcher & behave correctly
[Regression Potential]
* low.
* all code paths are well-tested.
Related branches
lp:~zaspire/unity-firefox-extension/tab-moving
- Robert Carr (community): Approve
- jenkins (community): Approve (continuous-integration)
-
Diff: 602 lines (+245/-163)6 files modifiedtests/testBradingRemover.js (+1/-1)
tests/testPreviewUtils.js (+12/-5)
unity-firefox-extension/bootstrap.js (+2/-4)
unity-firefox-extension/content/observer.js (+185/-1)
unity-firefox-extension/content/unity-global-property-initializer.js (+45/-100)
unity-firefox-extension/content/unity-view-manager.js (+0/-52)
visibility: | private → public |
Changed in unity-firefox-extension: | |
status: | Confirmed → Fix Committed |
status: | Fix Committed → In Progress |
assignee: | nobody → Maxim Ermilov (zaspire) |
Changed in unity-firefox-extension: | |
status: | In Progress → Fix Released |
summary: |
- Extension does not support moving windows between tabs (activity + Extension does not support moving tabs between windows (activity tracking degenerates) |
Changed in unity-firefox-extension (Ubuntu): | |
importance: | Undecided → Medium |
milestone: | none → quantal-updates |
description: | updated |
tags: |
added: verification-done removed: verification-needed |
To post a comment you must log in.
Hello Robert, or anyone else affected,
Accepted unity-firefox- extension into quantal-proposed. The package will build now and be available at http:// launchpad. net/ubuntu/ +source/ unity-firefox- extension/ 2.4.1-0ubuntu1 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification- failed. In either case, details of your testing will help us make a better decision.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance!