Attempt to unrescue in invalid state results in 500 error

Bug #965667 reported by Johannes Erdfelt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Johannes Erdfelt

Bug Description

An attempt to unrescue an instance in an invalid state results in a 500 error instead of the expected 409 error.

Looking at the code, the unrescue action doesn't catch InstanceInvalidState like it should.

Changed in nova:
assignee: nobody → Johannes Erdfelt (johannes.erdfelt)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5833

tags: added: essex-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/5833
Committed: http://github.com/openstack/nova/commit/575ad8f77dc7095c8a0ba9dd8deb41bf2fddae1f
Submitter: Jenkins
Branch: master

commit 575ad8f77dc7095c8a0ba9dd8deb41bf2fddae1f
Author: Johannes Erdfelt <email address hidden>
Date: Mon Mar 26 20:43:43 2012 +0000

    Fix unrescue in invalid state

    Fixes bug 965667

    Unrescue did not check for InstanceInvalidState exception and return the
    appropriate error.

    Change-Id: I3ca2c1dae09bd149086bfe67e2233c8359d5c8f8

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/6021

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (milestone-proposed)

Reviewed: https://review.openstack.org/6021
Committed: http://github.com/openstack/nova/commit/fe3b7bfe79b4fc99aa1e8920aabdaeceaf4d6882
Submitter: Jenkins
Branch: milestone-proposed

commit fe3b7bfe79b4fc99aa1e8920aabdaeceaf4d6882
Author: Johannes Erdfelt <email address hidden>
Date: Mon Mar 26 20:43:43 2012 +0000

    Fix unrescue in invalid state

    Fixes bug 965667

    Unrescue did not check for InstanceInvalidState exception and return the
    appropriate error.

    Change-Id: I3ca2c1dae09bd149086bfe67e2233c8359d5c8f8

Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: none → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.