Ubuntu
zookeeper package

Memory leak on any async python call

Bug #963280 reported by Kapil Thangavelu on 2012-03-23

6

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	zookeeper (Ubuntu)	Fix Released	High	James Page	Ubuntu ubuntu-12.04-beta-2
	Precise	Fix Released	High	James Page	Ubuntu ubuntu-12.04-beta-2

Bug Description

There is a missing Py_DECREF on all the results. For large results this can lead to a significant memory growth per call. Credits to Johan Rydberg for pointing out the issue to me and providing a sample program to reproduce. Patch and sample prog to be attached.

Related branches

lp:ubuntu/precise/zookeeper

Revision history for this message

Kapil Thangavelu (hazmat) wrote on 2012-03-23:

#1

sample program using txzookeeper to reproduce the memory leak Edit (1.1 KiB, text/x-python)

Sample program attached to reproduce leak.

Revision history for this message

Kapil Thangavelu (hazmat) wrote on 2012-03-23:

#2

patch against 3.3 branch for mem fix leak Edit (2.1 KiB, text/plain)

patch to fix attached, generated against 3.3 branch it should apply cleanly to 3.3.4 and 3.3.5

James Page (james-page) on 2012-03-23

Changed in zookeeper (Ubuntu):
importance:	Undecided → High
milestone:	none → ubuntu-12.04-beta-2

Revision history for this message

Clint Byrum (clint-fewbar) wrote on 2012-03-23:

#3

Reproducible, so marking Confirmed. Should be forwarded along to upstream now.

Changed in zookeeper (Ubuntu Precise):
status:	New → Confirmed

Revision history for this message

James Page (james-page) wrote on 2012-03-23:

#4

https://issues.apache.org/jira/browse/ZOOKEEPER-1431

Changed in zookeeper (Ubuntu Precise):
assignee:	nobody → James Page (james-page)
status:	Confirmed → In Progress

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-03-23:

#5

This bug was fixed in the package zookeeper - 3.3.5+dfsg1-1ubuntu1

---------------
zookeeper (3.3.5+dfsg1-1ubuntu1) precise; urgency=low

  * d/patches/fixes/ZOOKEEPER-1431: Fix up memory leak in zookeeper
    python binding which results in significant memory growth for large
    result sets (LP: #963280). Thanks to Johan Rydberg for identifying
    this bug and Kapil Thangavelu for the patch.
-- James Page <email address hidden> Fri, 23 Mar 2012 17:33:38 +0000

Changed in zookeeper (Ubuntu Precise):
status:	In Progress → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Patches

patch against 3.3 branch for mem fix leak Edit

Add patch

Bug attachments

sample program using txzookeeper to reproduce the memory leak Edit

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.