Fail-fast for invalid read_deleted values

Bug #961588 reported by Rick Harris
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Rick Harris

Bug Description

`read_deleted` is a tri-valued variable ('yes', 'no', 'only').

Somehow it's getting set to True, but grep'ing through the code, it's not obvious where this is happening.

Moreover, the tracebacks we're getting are pretty useless b/c it looks like it's taking on the invalid way before the exception is triggered.

To fix this, I suggest making `read_deleted` a property so that we can fail immediately if an invalid value is attempted.

Changed in nova:
assignee: nobody → Rick Harris (rconradharris)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5645

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/5645
Committed: http://github.com/openstack/nova/commit/521108d5b91d7a7aa2ff1e594f3dc48d0c2a7311
Submitter: Jenkins
Branch: master

commit 521108d5b91d7a7aa2ff1e594f3dc48d0c2a7311
Author: Rick Harris <email address hidden>
Date: Wed Mar 21 20:14:39 2012 +0000

    Fail-fast for invalid read_deleted values

    Fixes bug 961588

    Change-Id: Ib02d89485cdf4626698b959a2136841109cdc51f

Changed in nova:
status: In Progress → Fix Committed
Devin Carlen (devcamcar)
Changed in nova:
milestone: none → folsom-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.