Limit boot loader installation target
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubiquity (Ubuntu) |
Fix Released
|
Medium
|
Barry Warsaw |
Bug Description
In bug 933433 the user attempted to install the boot loader on an XFS file system, which does not reserve space. This causes a follow-on bug that will be fixed separately as part of bug 933433. However, in general, cjwatson says:
<cjwatson> barry: firstly, the user was allowed to select an XFS partition as
a target for boot loader installation (impossible since XFS doesn't
reserve space) [17:22]
<cjwatson> actually should not be allowed to select anything that doesn't
reserve embedding space
<cjwatson> that can be data-mined from the grub2 source
<cjwatson> 'grep reserved_
<cjwatson> if there's a filesystem in the target partition, it must be one of
those with = 1 there
Related branches
- Colin Watson (community): Approve
- Evan (community): Approve
-
Diff: 511 lines (+372/-23) (has conflicts)4 files modifieddebian/changelog (+9/-0)
tests/test_ubi_partman.py (+284/-3)
ubiquity/frontend/kde_components/PartMan.py (+4/-2)
ubiquity/plugins/ubi-partman.py (+75/-18)
Changed in ubiquity (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in ubiquity (Ubuntu): | |
assignee: | nobody → Barry Warsaw (barry) |
status: | Triaged → Fix Committed |
So, doing the grep as you suggest gives me these supportable filesystems:
'btrfs',
'ext2',
'fat',
'hfsplus',
'nilfs2',
'ntfs',
so I think you have to special case (i.e. manually add to the list) ext3 and ext4 also, and probably fat16 and fat32 too. Am I missing something?