Search term goes away on exaile close/reopen and filter can no longer be removed

[Alin Claudiu Radut]

Binary package hint: exaile

1. Load a playlist (or entire library)
2. Type something into search box and wait for the tracks to be filtered
3. Close exaile
4. Reopen exaile

The tracks listed are filtered by the string from (2), but the search box is empty and the title of the tab still says "Entire library" or the playlist's name. This is very confusing to the user. Also, now the user has to reload the entire playlist because the filter set at (2) can no longer be removed (basically this acts like a completely new playlist now).

A visual cue should be added in the title of the tab to notify the user that the playlist is filtered and a way to remove the filter after reopening should also be added.

Edit: forgot to mention, I'm using Edgy and Exaile version is 0.2.8

[François Févotte (francois-fevotte)]

Hi,

thanks for reporting this bug. You seem to be experiencing the same problem as in upstream bug #311 (http://www.exaile.org/trac/ticket/311).

[Khristian Alexander Schönrock (der-kosak)]

I'm experiencing the same bug here. The playlist has to be reloaded for other tracks to appear in the playlist.
Using exaile.py 0.2.10 on Ubuntu Gutsy

[Dan O'Reilly (oreilldf)]

Here's a patch that will clear the filter when exaile is exited, so that the whole playlist gets saved. I'm not sure if this is the preferred method though. You could also save the filter applied when quit to disk, clear it, save the whole playlist as well, then reapply the filter on open.

[Dan O'Reilly (oreilldf)]

Bumping this one up.

[Dan O'Reilly (oreilldf)]

I forgot that I had updated this a little since I had initially posted it that fixes an error caused by trying to quit before any playlists have loaded.

[Adam Olsen (arolsen)]

Committed latest patch

[Eric Stein (estein)]

As mentioned above, fix is committed.

[Mathieu Leplatre (mathieu.leplatre)]

Submitted debdiff.
Not yet published in archive.

[Mathieu Leplatre (mathieu.leplatre)]

Modified the changelog entry from (Closes #95860) to (LP: #95860).

(Sorry...this is my first patch!)

[Luca Falavigna (dktrkranz)]

Mathieu, you should attach a new debdiff, this time invoking
debdiff exaile_0.2.11.1-0ubuntu2.dsc exaile_0.2.11.1-0ubuntu3.dsc

Thanks!

[Mathieu Leplatre (mathieu.leplatre)]

Thank you Luca.
I did everything again, and the patch looks ok (+ signs...)
I feel ashame, I have to make up !
Hope it is fine now.

[Siegfried Gevatter (rainct)]

This is marked as "Fix commited" but u-u-s is still subscribed. Has the fix already been uploaded?

[Mathieu Leplatre (mathieu.leplatre)]

I had the fix uploaded, and subscribed u-u-s.

[Luca Falavigna (dktrkranz)]

Now debdiff is correct, but since exaile does use of dpatch, you should use it to include your changes.
See https://wiki.ubuntu.com/PackagingGuide/PatchSystems for further reference.

[Mathieu Leplatre (mathieu.leplatre)]

I completely forgot about this bug...

Alright, now I used dpatch (a lot of documentation, but very few step by step procedure... kind of tough).

Hope everything is well, at least when I look at it, I can see all my changes.

Can somebody have a look before I submitted it to universe please ?

Thanks !

[Daniel Holbach (dholbach)]

Please don't subscribe ubuntu-universe-contributors.

[Mathieu Leplatre (mathieu.leplatre)]

Used dpatch. And made a step by step tutorial to remember :
http://mathieu-leplatre.info/dokuwiki/doku.php?id=en:apply_debian_patches_step-by-step

[Luca Falavigna (dktrkranz)]

This doesn't seem to be fixed in Intrepid, setting as Confirmed to attract sponsors.

[Luca Falavigna (dktrkranz)]

Mathieu, mind preparing a debdiff against 0.2.13-0ubuntu1 in Intrepid? Current one is against Hardy version.
Please, resubscribe ubuntu-universe-sponsors when ready, thanks!

[Mathieu Leplatre (mathieu.leplatre)]

Luca, Intrepid package already includes those patches.

[David Hardstone (dhardstone)]

This appears to be fixed for me in Exaile 0.2.14.

[David Hardstone (dhardstone)]

My bad, already marked fixed. Sorry for being a newbie!

[Andrew Starr-Bochicchio (andrewsomething)]

As already noted above, this fix has already been in Ubuntu for sometime. Changing to Fix Released for Ubuntu as well.