ec2: Associate non-existent floating ip yields Unknown Error

[Anthony Young]

Steps to repro:

> run devstack
> create instance
> euca-allocate-address
> euca-associate-address -i [id] 172.3.3.3

Expected:

Error message telling me the address can not be found

Actual:

$ euca-associate-address 172.24.2.225 -i i-b
UnknownError: An unknown error has occurred. Please try your request again.

api log:

(nova.api.ec2): TRACE: Traceback (most recent call last):
(nova.api.ec2): TRACE: File "/opt/stack/nova/nova/api/ec2/__init__.py", line 582, in __call__
(nova.api.ec2): TRACE: result = api_request.invoke(context)
(nova.api.ec2): TRACE: File "/opt/stack/nova/nova/api/ec2/apirequest.py", line 81, in invoke
(nova.api.ec2): TRACE: result = method(context, **args)
(nova.api.ec2): TRACE: File "/opt/stack/nova/nova/api/ec2/cloud.py", line 1276, in associate_address
(nova.api.ec2): TRACE: address=public_ip)
(nova.api.ec2): TRACE: File "/opt/stack/nova/nova/compute/api.py", line 100, in wrapped
(nova.api.ec2): TRACE: return func(self, context, target, *args, **kwargs)
(nova.api.ec2): TRACE: File "/opt/stack/nova/nova/compute/api.py", line 1634, in associate_floating_ip
(nova.api.ec2): TRACE: floating_address=address, fixed_address=ips[0]['address'])
(nova.api.ec2): TRACE: File "/opt/stack/nova/nova/network/api.py", line 146, in associate_floating_ip
(nova.api.ec2): TRACE: 'affect_auto_assigned': affect_auto_assigned}})
(nova.api.ec2): TRACE: File "/opt/stack/nova/nova/rpc/__init__.py", line 68, in call
(nova.api.ec2): TRACE: return _get_impl().call(context, topic, msg, timeout)
(nova.api.ec2): TRACE: File "/opt/stack/nova/nova/rpc/impl_kombu.py", line 674, in call
(nova.api.ec2): TRACE: return rpc_amqp.call(context, topic, msg, timeout, Connection.pool)
(nova.api.ec2): TRACE: File "/opt/stack/nova/nova/rpc/amqp.py", line 338, in call
(nova.api.ec2): TRACE: rv = list(rv)
(nova.api.ec2): TRACE: File "/opt/stack/nova/nova/rpc/amqp.py", line 306, in __iter__
(nova.api.ec2): TRACE: raise result
(nova.api.ec2): TRACE: RemoteError: Remote error: FloatingIpNotFoundForAddress Floating ip not found for address 172.24.2.225.
(nova.api.ec2): TRACE: [u'Traceback (most recent call last):\n', u' File "/opt/stack/nova/nova/rpc/amqp.py", line 252

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/6950

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/6950
Committed: http://github.com/openstack/nova/commit/8b597f76f980769e83a36111ca8fcd8b988d236c
Submitter: Jenkins
Branch: master

commit 8b597f76f980769e83a36111ca8fcd8b988d236c
Author: Chuck Short <email address hidden>
Date: Mon Apr 30 21:36:06 2012 -0400

    Make allocation failure a bit more friendly

    If the user allocates the wrong address display
    a message about incorrect address rather than a traceback.

    Fixes LP: #957707

    Change-Id: I8ccd3056f755afb9f873a25fd494428e481ff3a2
    Signed-off-by: Chuck Short <email address hidden>