glance add throws: IndexError: tuple index out of range

[Dan Prince]

Adding glance images now throws the following exception if you run it in a shell without a TTY?

ssh nova1 bash <<-"EOF_BASH"
glance add name="ari-tty" type="ramdisk" disk_format="ari" container_format="ari" is_public=true < /tmp/tty_linux/ramdisk
EOF_BASH

------
stty: standard input: Inappropriate ioctl for device
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib64/python2.7/threading.py", line 552, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/site-packages/glance/common/animation.py", line 67, in run
    self.render()
  File "/usr/lib/python2.7/site-packages/glance/common/animation.py", line 105, in render
    height, width = utils.get_terminal_size()
  File "/usr/lib/python2.7/site-packages/glance/common/utils.py", line 369, in get_terminal_size
    return height_width[0], height_width[1]
IndexError: tuple index out of range

[Dan Prince (dan-prince)]

I *think* the breaking commit is here:

https://github.com/openstack/glance/commit/ee2d212f81a20d31ea6a815453911d01e39a1c84#L12L330

[Dan Prince (dan-prince)]

The issue seems to be that we just need a little error checking:

        if not height_width:
            try:
                p = subprocess.Popen(['stty', 'size'],
                                    shell=False,
                                    stdout=subprocess.PIPE)
                result = p.communicate()
                if p.returncode == 0:
                    return tuple(int(x) for x in result[0].split())
            except:
                pass

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/5404

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/5404
Committed: http://github.com/openstack/glance/commit/0a19061141de1fb70c5e3dc1a5e47f11f5b068fe
Submitter: Jenkins
Branch: master

commit 0a19061141de1fb70c5e3dc1a5e47f11f5b068fe
Author: Dan Prince <email address hidden>
Date: Thu Mar 15 13:28:20 2012 -0400

    Add error checking to get_terminal_size.

    Adds returncode error checking to get_terminal_size so that
    it doesn't spew errors to console when running glance commands
    in a shell without a TTY.

    Fixes LP Bug #956202.

    Change-Id: I42e155d168da1f4f25c0dea9ad9768686bd654ce