username vs. name in token["user"] dict

[Brian Lamar]

Unsure how else to title this issue. I just encountered a rather subtle discrepancy between the docs and code. Keystone's API docs indicate that token["user"] will have keys "id", "name", "roles", and "roles_links". However, the auth_token.py middleware checks for token["user"]["username"]. Actually, it seems that keystone returns both "user" and "username" with identical values:

http://paste.openstack.org/show/9451/

Can we standardize on "name" to match the docs?

http://docs.openstack.org/api/openstack-identity-service/2.0/content/POST_authenticate_v2.0_tokens_Service_API_Client_Operations.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/5374

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/5374
Committed: http://github.com/openstack/keystone/commit/ab6be05068068b0902db44b1d60f56eea4fe1215
Submitter: Jenkins
Branch: master

commit ab6be05068068b0902db44b1d60f56eea4fe1215
Author: Brian Lamar <email address hidden>
Date: Wed Mar 14 18:30:13 2012 -0400

    Update username -> name in token response.

    Tokens validation responses contain user information. The API docs
    seem to indicate token["user"]["name"] contains the username but
    currently the auth_token.py middleware checks for
    token["user"]["username"]. This updates that check and the tests.

    Fixes bug 955563

    Change-Id: Ib2fbf6fcea87f7066394cf14c18158f1e5eeaf06