UI Semantics: Table headers should use the <caption> tag within the table itself instead of a div outside of the table

Bug #953741 reported by John Postlethwait
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
John Postlethwait

Bug Description

Many of the data tables in Horizon have captions that are a div with a class of table_header. This is semantically incorrect. The table element itself should have a <caption> element that contains this information (as it IS a table caption). Using a caption would look no different, but would allow the tables to semantically contain all of their own information, including their headers and actions (caption element.) See here for more on the caption element: http://www.w3schools.com/tags/tag_caption.asp

This will prevent UI issues too when the page is a small width where the table shrinks less than the div is willing to. See attached as to what I am speaking of here.

Revision history for this message
John Postlethwait (john-postlethwait) wrote :
Revision history for this message
John Postlethwait (john-postlethwait) wrote :

By the way, this should by NO MEANS be a blocker for essex-rc1, it is an improvement that should happen after that...

Revision history for this message
Gabriel Hurley (gabriel-hurley) wrote :

This seems reasonable to me, as long as it's semantically correct to put the actions inside the caption element as well.

Changed in horizon:
importance: Undecided → Low
status: New → Confirmed
Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5482

Changed in horizon:
assignee: nobody → John Postlethwait (john-postlethwait)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/5482
Committed: http://github.com/openstack/horizon/commit/9fbca5643974d0f1a53d4989685a4af79198fb08
Submitter: Jenkins
Branch: master

commit 9fbca5643974d0f1a53d4989685a4af79198fb08
Author: John Postlethwait <email address hidden>
Date: Sat Mar 17 15:10:09 2012 -0700

    Using the <caption> tag for table captions. Fixes bug #953741

    Change-Id: I68873292cefac3ad9426f235c228522db3cf171f

Changed in horizon:
status: In Progress → Fix Committed
Devin Carlen (devcamcar)
Changed in horizon:
milestone: none → essex-rc1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.