remove old sql api calls

[Dan Prince]

The following SQL api calls appears to be unused in nova and we should probably consider removing them:

service_get_all_network_sorted
compute_node_get_by_service
compute_node_get_for_service
compute_node_capacity_find
instance_stop
instance_get_all_by_user
network_count_allocated_ips
network_count_available_ips
network_disassociate_all
security_group_destroy_all
provider_fw_rule_get_all_by_cidr
project_get_networks_v6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/5236

[Dan Prince (dan-prince)]

The following calls also appears to be unused however I was unsure as to whether they are related to missing features or are just cruft.

certificate_destroy (probably cruft)
certificate_update (cruft?)

sm_volume_update (are we missing a nova-manage command for this?)
sm_volume_get_all (missing nova-manage command for this?)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/5236
Committed: http://github.com/openstack/nova/commit/6fd9d326d97b24ee203b0cf3074074864283178d
Submitter: Jenkins
Branch: master

commit 6fd9d326d97b24ee203b0cf3074074864283178d
Author: Dan Prince <email address hidden>
Date: Mon Mar 12 13:55:21 2012 -0400

    Nuke some unused SQL api calls.

    Fixes LP bug #953235.

    Change-Id: Iafb33a74397a9037c31718018275d3a7d064f59b

[Vish Ishaya (vishvananda)]

On Mar 12, 2012, at 11:23 AM, Dan Prince wrote:

> The following calls also appears to be unused however I was unsure as to
> whether they are related to missing features or are just cruft.
>
> certificate_destroy (probably cruft)

yeah we revoke them and never destroy them

> certificate_update (cruft?)

can't see why we would need to update an existing cert
>
> sm_volume_update (are we missing a nova-manage command for this?)
> sm_volume_get_all (missing nova-manage command for this?)

Renuka might be able to comment on whether this stuff is needed.

Vish

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/5733

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/5733
Committed: http://github.com/openstack/nova/commit/64c1593503c1f8879515123d1baffad56ae963f9
Submitter: Jenkins
Branch: master

commit 64c1593503c1f8879515123d1baffad56ae963f9
Author: Dan Prince <email address hidden>
Date: Fri Mar 23 11:00:05 2012 -0400

    Remove unused certificate SQL calls.

    Remove unused certificate_destroy and certificate_update functions
    from the DB api.

    Fixes LB Bug #953235.

    Change-Id: I2e3e07235467b2a5a11e228c2ed8db752c403ce3

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/5882

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/5882
Committed: http://github.com/openstack/nova/commit/61a7ae8de318da052addffab0cd3340ad3e345c8
Submitter: Jenkins
Branch: milestone-proposed

commit 61a7ae8de318da052addffab0cd3340ad3e345c8
Author: Dan Prince <email address hidden>
Date: Fri Mar 23 11:00:05 2012 -0400

    Remove unused certificate SQL calls.

    Remove unused certificate_destroy and certificate_update functions
    from the DB api.

    Fixes LB Bug #953235.

    Change-Id: I2e3e07235467b2a5a11e228c2ed8db752c403ce3