inconsistent use of getLogger in keystone

Bug #948224 reported by Joseph Heck
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Dolph Mathews

Bug Description

within the keystone codebase and middleware, we use "log = logging.getLogger..." a bit inconsistently. This bug is to run through the instances where we instantiate it, and set it to:

 LOG = logging.getLogger('keystone.module.name.here') and update it's usage.

Also - add that detail to HACKING.rst

Dolph Mathews (dolph)
Changed in keystone:
assignee: nobody → Dolph Mathews (dolph)
Revision history for this message
Dolph Mathews (dolph) wrote :

We can (and do) also:

    from keystone import logging

    logging.debug('foobar')

... so I assume we should also update keystone.logging to prevent this from being possible?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5357

Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/5357
Committed: http://github.com/openstack/keystone/commit/678dcad410b2496eb1ed34bb91c0d0914a9c6b0d
Submitter: Jenkins
Branch: master

commit 678dcad410b2496eb1ed34bb91c0d0914a9c6b0d
Author: Dolph Mathews <email address hidden>
Date: Wed Mar 14 14:28:04 2012 -0500

    Refactor keystone.common.logging use (bug 948224)

    Change-Id: I01b2b5748a2524273bb8c2b734ab22415652f739

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → essex-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.