VDI cleanup needs to shutdown VM first

[Rick Harris]

If an exception is raised after the VM spawn, in the configuration phase, this error can be generated:

http://paste.openstack.org/show/5490/

This comes about b/c we're trying to remove a VDI from a successfully spawned VM.

The solution here is to shutdown the VM and remove the VM before cleaning up the VDIs.

Only XenAPI.Failure, IOError and OSErrors will trigger this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/4713

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/4713
Committed: http://github.com/openstack/nova/commit/b6a175664042dfd486fa6217b5e199a46dacefb6
Submitter: Jenkins
Branch: master

commit b6a175664042dfd486fa6217b5e199a46dacefb6
Author: Rick Harris <email address hidden>
Date: Wed Feb 29 18:39:13 2012 +0000

    Destroy VM before VDIs during spawn cleanup

    Fixes bug 943453

    Change-Id: I65fd4c61f9f91abeb04d0d1956506a1c69cef72e