Subject links in rdetail_summary.xml don't display tooltips

[Michael Peters]

Evergreen 2.1 - master
Debian Squeeze
Postgres 9.1

Evergreen Indiana discovered that the "Subjects" links from the record summary do not offer a tool tip in the same manner that Author links do.

Mouse over the author on rdetail_summary.xml and you'll get a tooltip that reads "Perform an author search". We expected the same for Subject(s) but they're not currently coded.

[Michael Peters (mrpeters)]

Subjects display, currently

[Minoshini (minoshini-fon)]

I am newer to Evergreen community. I think that you are mentioning on having a tooltip on a element
I think this can be done through jQuery easily. A simple html can be added to get it done in a simple way.

<a href="rdetail_summary.xml" class="tooltip" title="Hary Potter">Subject</a>

[Jason Etheridge (phasefx)]

> I am newer to Evergreen community. I think that you are mentioning on having a tooltip on a element
> I think this can be done through jQuery easily.  A simple html can be added to get it done in a simple way.

Hi Minoshini,

There are two patron-facing web interfaces for Evergreen, referred to
as the tpac (uses perl template toolkit and little to no javascript)
and the jspac (which is heavy DHTML, and Dojo). This bug refers to
the jspac, but neither use jQuery. Ideally, you'd look to see how the
tooltips are working for the author links and make the subject links
work the same way.

Thanks!
-- Jason

[Dan Scott (denials)]

Hi, we use "In Progress" to indicate that a committer is testing a proposed branch or patch, so I'm setting this back to the previous status until such time as the bug has been tagged "pullrequest" and a committer starts looking at it.

[Rajul Bhatnagar (rajulbhatnagar93)]

Sorry Sir.

On 6 April 2012 21:07, Dan Scott <email address hidden> wrote:

> Hi, we use "In Progress" to indicate that a committer is testing a
> proposed branch or patch, so I'm setting this back to the previous
> status until such time as the bug has been tagged "pullrequest" and a
> committer starts looking at it.
>
> ** Changed in: evergreen
> Status: In Progress => New
>
> ** Changed in: evergreen
> Assignee: Rajul Bhatnagar (rajulbhatnagar93) => (unassigned)
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/942172
>
> Title:
> Subject links in rdetail_summary.xml don't display tooltips
>
> Status in Evergreen - Open ILS:
> New
>
> Bug description:
> Evergreen 2.1 - master
> Debian Squeeze
> Postgres 9.1
>
> Evergreen Indiana discovered that the "Subjects" links from the record
> summary do not offer a tool tip in the same manner that Author links
> do.
>
> Mouse over the author on rdetail_summary.xml and you'll get a tooltip
> that reads "Perform an author search". We expected the same for
> Subject(s) but they're not currently coded.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/942172/+subscriptions
>

--
*Rajul Bhatnagar
Btech Computer Science & Engineering
VIT University Vellore*

[Rajul Bhatnagar (rajulbhatnagar93)]

I have added an Entity for subject search on similar lines as author search and added a title attribute in rdetail_summary.xml which references to that entity.

[Michael Peters (mrpeters)]

Rajul -- for future reference, a push to the evergreen-ils.org Git server is preferable to Github, as it makes it easier for folks to test, signoff, and commit your submission.

Some great information on getting started with that is available at http://evergreen-ils.org/dokuwiki/doku.php?id=dev:git

As for commit messages, at a minimum, the commit message should consist of a subject line (i.e., the first line of the commit message), then a blank line, then an optional description of the patch, followed by one or more signoffs. The subject line should be brief, ideally no more than 60-70 characters, and should include a bug number from LaunchPad if relevant. Here is an example of a minimum commit message:

LP#24544: fix the quuxifier
Signed-off-by: Jane Hacker <email address hidden>

If you need any help getting started with submitting code this way in the future, please feel free to reach out to me (or any of the other devs) via email, or the Evergreen IRC chat. (#evergreen on Freenode.net).

Thank you, again, for your quick work in solving this bug! Once it's in a proper git repo I'm sure it will get some eyes on it.

[Michael Peters (mrpeters)]

I tested this against master and actually find that this breaks the subject display.

Testing with a record:

650 0. ‡aScience fiction, American.
650 0. ‡aDetective and mystery stories, American.

With this code, I get no display of these subjects. As soon as I roll back to master, all is well.

[Michael Peters (mrpeters)]

To make for easier testing, I've pushed a branch for you, this time Rajul.

user/mrpeters-isl/fix_rdetail_summary_subject_tooltip
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=31b0364e63629461482d5fcae2e6c43ce0302993

Thank you for your submission, Rajul, and hopefully we can get it working!

[Rajul Bhatnagar (rajulbhatnagar93)]

This is a patch for the new branch you made sir.
I used the wrong type of quotes so I think that was causing the script to fail.

[Michael Peters (mrpeters)]

Rajul,

I just am curious if you are testing your patches before you send them in? This second patch still doesn't resolve the bug.

Have a look at the tooltips on: http://master.evergreen.lib.in.us/opac/en-US/skin/default/xml/rdetail.xml?r=120&t=Baseball&tp=keyword&d=0&hc=4&rt=keyword

You can see, the title string is not properly pulling in the string from opac.dtd.

Thank you, certainly, for your submissions. Just would like to know if this is tested and working in your environment, because I'm still unable to get it to work.

Thanks,
Mike

[Dan Scott (denials)]

Sadly, the patch can't possibly work as intended because that JavaScript section is marked as CDATA, which prevents XMLENT from substituting the value of the entity.

I think you would want to look at using dojo.i18n to provide a translated string in this case.

[Dan Wells (dbw2)]

Maybe not elegant, but you could also simply stop and restart the CDATA section around the entity to get it to translate.

[Rajul Bhatnagar (rajulbhatnagar93)]

Ok sir.I'll try that.

On 12 April 2012 21:08, Dan Wells <email address hidden> wrote:

> Maybe not elegant, but you could also simply stop and restart the CDATA
> section around the entity to get it to translate.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/942172
>
> Title:
> Subject links in rdetail_summary.xml don't display tooltips
>
> Status in Evergreen - Open ILS:
> New
>
> Bug description:
> Evergreen 2.1 - master
> Debian Squeeze
> Postgres 9.1
>
> Evergreen Indiana discovered that the "Subjects" links from the record
> summary do not offer a tool tip in the same manner that Author links
> do.
>
> Mouse over the author on rdetail_summary.xml and you'll get a tooltip
> that reads "Perform an author search". We expected the same for
> Subject(s) but they're not currently coded.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/942172/+subscriptions
>

--
*Rajul Bhatnagar
Btech Computer Science & Engineering
VIT University Vellore*

[Michael Peters (mrpeters)]

Rajul,

It would be preferable if you were able to get your SSH keys submitted, and push your next fix to the working repo. It would save us all a lot of time!

Some great information on getting started with that is available at http://evergreen-ils.org/dokuwiki/doku.php?id=dev:git

Thanks!
Mike Peters

[Rajul Bhatnagar (rajulbhatnagar93)]

I will do that Sir.

On 12 April 2012 22:05, Michael Peters <email address hidden> wrote:

> Rajul,
>
> It would be preferable if you were able to get your SSH keys submitted,
> and push your next fix to the working repo. It would save us all a lot
> of time!
>
> Some great information on getting started with that is available at http
> ://evergreen-ils.org/dokuwiki/doku.php?id=dev:git
>
> Thanks!
> Mike Peters
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/942172
>
> Title:
> Subject links in rdetail_summary.xml don't display tooltips
>
> Status in Evergreen - Open ILS:
> New
>
> Bug description:
> Evergreen 2.1 - master
> Debian Squeeze
> Postgres 9.1
>
> Evergreen Indiana discovered that the "Subjects" links from the record
> summary do not offer a tool tip in the same manner that Author links
> do.
>
> Mouse over the author on rdetail_summary.xml and you'll get a tooltip
> that reads "Perform an author search". We expected the same for
> Subject(s) but they're not currently coded.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/942172/+subscriptions
>

--
*Rajul Bhatnagar
Btech Computer Science & Engineering
VIT University Vellore*

[Jason Stephenson (jstephenson)]

JSPAC is now deprecated, so I'm inclined to say Won't Fix.