setup.py installs three libraries into Python libs dir
Bug #941255 reported by
Duncan McGreggor
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Accomplishments System |
Invalid
|
Undecided
|
Duncan McGreggor | ||
Bug Description
This project installs the following into the Python libs dir:
* daemon
* trophyinfo
* trophyinfo_lib
The first one isn't such a good idea, since it's such a generic name... and someone else might have already used that name. Even if that's not the case, it's not good practice to install something in the Python lib space that isn't readily identifiable.
As for the second two, there's needless separation here: one is providing base classes for another.
All told, there's no reason to separate these three. Ideally, the code would be refactored to include them all in the same Python package.
Note that this also requires changes to the community contributions, and that work is being tracked in a separate ticket/branch: bug #946809.
Related branches
lp:~oubiwann/ubuntu-accomplishments-system/941255-unified-source-dir
- Jono Bacon: Approve
- Duncan McGreggor (community): Needs Resubmitting
-
Diff: 2827 lines (+496/-1289)26 files modifiedAUTHORS (+2/-1)
accomplishments/config.py (+1/-54)
accomplishments/daemon/app.py (+111/-101)
accomplishments/daemon/dbusapi.py (+2/-2)
accomplishments/daemon/tests/tests.py (+17/-15)
accomplishments/exceptions.py (+32/-0)
accomplishments/gui/AboutTrophyinfoDialog.py (+9/-7)
accomplishments/gui/PreferencesTrophyinfoDialog.py (+8/-4)
accomplishments/gui/TrophyinfoWindow.py (+46/-48)
accomplishments/gui/base/AboutDialog.py (+5/-5)
accomplishments/gui/base/Builder.py (+9/-9)
accomplishments/gui/base/PreferencesDialog.py (+10/-9)
accomplishments/gui/base/Window.py (+17/-12)
accomplishments/gui/base/__init__.py (+2/-3)
accomplishments/gui/base/helpers.py (+10/-36)
accomplishments/main.py (+6/-27)
accomplishments/util/__init__.py (+88/-0)
accomplishments/util/dist.py (+75/-0)
bin/rundaemon.sh (+2/-2)
bin/trophyinfo (+10/-6)
daemon/libaccomplishments-daemon/trophy-accomplished.svg (+0/-854)
data/ui/TrophyinfoWindow.ui (+1/-1)
setup.py (+6/-75)
tests/test_example.py (+13/-7)
tests/test_lint.py (+13/-10)
trophyinfo.desktop.in (+1/-1)
lp:~oubiwann/ubuntu-community-accomplishments/946809-module-changes
- Duncan McGreggor (community): Approve
- Jono Bacon: Disapprove
-
Diff: 808 lines (+127/-194)14 files modifiedscripts/ubuntu-community/community-council-member.py (+8/-13)
scripts/ubuntu-community/core-dev.py (+8/-13)
scripts/ubuntu-community/first-bug-confirmed.py (+12/-14)
scripts/ubuntu-community/first-bug.py (+12/-13)
scripts/ubuntu-community/fridge-editor.py (+8/-14)
scripts/ubuntu-community/juju-charm-contributor.py (+10/-15)
scripts/ubuntu-community/juju-charm-reviewer.py (+8/-15)
scripts/ubuntu-community/loco-council-member.py (+10/-16)
scripts/ubuntu-community/member-loco-team.py (+9/-13)
scripts/ubuntu-community/motu.py (+8/-15)
scripts/ubuntu-community/registered-on-launchpad.py (+10/-12)
scripts/ubuntu-community/signed-code-of-conduct.py (+8/-11)
scripts/ubuntu-community/technical-board-member.py (+8/-15)
scripts/ubuntu-community/ubuntu-member.py (+8/-15)
| Changed in ubuntu-accomplishments-system: | |
| assignee: | nobody → Duncan McGreggor (oubiwann) |
| status: | New → In Progress |
| description: | updated |
| description: | updated |
| Changed in ubuntu-accomplishments-system: | |
| status: | In Progress → Invalid |
To post a comment you must log in.
