Can't delete keypair with a slash

Bug #937408 reported by justinsb
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Justin Shepherd

Bug Description

When I create a keypair with a forward slash in the name, I can't delete it.

It doesn't matter whether or not I escape it, I get a 404 regardless. It never hits the controller.

1 > DELETE http://192.168.71.1:8774/v1.1/b560b4f9ab4a4941b3bafbb44e3e100b/os-keypairs/J%2FSB
1 > Accept: application/json

I think keypairs with slashes in the name should be disallowed.

Thierry Carrez (ttx)
Changed in nova:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/4579

Changed in nova:
assignee: nobody → Justin Shepherd (jshepher)
status: Confirmed → In Progress
Changed in nova:
assignee: Justin Shepherd (jshepher) → Brian Waldon (bcwaldon)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/4579
Committed: http://github.com/openstack/nova/commit/c8b0a9a3be7ca276d91d470a629fdd0209812993
Submitter: Jenkins
Branch: master

commit c8b0a9a3be7ca276d91d470a629fdd0209812993
Author: Justin Shepherd <email address hidden>
Date: Sun Feb 26 22:23:30 2012 -0600

    Ensures that keypair names are only AlphaNumeric.

    Throws a 400 error if keypair contains any unsafe characters.

    Safe characters are '_-', digits, and ascii_leters.

    Added test_keypair_create_with_non_alphanumeric_name.

    Fixes bug 937408.

    Change-Id: If9b1393ee8f36113d2fa8a3b97ca526cc2e6ccf1

Changed in nova:
status: In Progress → Fix Committed
Brian Waldon (bcwaldon)
Changed in nova:
assignee: Brian Waldon (bcwaldon) → Justin Shepherd (jshepher)
Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.