monotone version 1.0-3 FTBFS on i386 in precise

[Andreas Moog]

This is a semi-automatic report based on the latest archive rebuild results [1].
Apologies if it reaches you in error.

Excerpt from the buildlog:

g++ -I. -I/usr/include/lua5.1 -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Wall -W -Wno-unused -c -o src/rcs_file.o src/rcs_file.cc
src/rcs_file.cc:45:1: error: redefinition of 'struct file_handle'
/usr/include/i386-linux-gnu/bits/fcntl.h:239:8: error: previous definition of 'struct file_handle'
src/rcs_file.cc: In function 'void parse_rcs_file(const string&, rcs_file&)':
src/rcs_file.cc:492:34: error: no matching function for call to 'file_handle::file_handle(const string&)'
src/rcs_file.cc:492:34: note: candidates are:
/usr/include/i386-linux-gnu/bits/fcntl.h:239:8: note: file_handle::file_handle()
/usr/include/i386-linux-gnu/bits/fcntl.h:239:8: note: candidate expects 0 arguments, 1 provided
/usr/include/i386-linux-gnu/bits/fcntl.h:239:8: note: file_handle::file_handle(const file_handle&)
/usr/include/i386-linux-gnu/bits/fcntl.h:239:8: note: no known conversion for argument 1 from 'const string {aka const std::basic_string<char>}' to 'const file_handle&'
src/rcs_file.cc:493:40: error: 'struct file_handle' has no member named 'fd'
src/rcs_file.cc:493:51: error: 'struct file_handle' has no member named 'length'
make[4]: *** [src/rcs_file.o] Error 1
make[4]: Leaving directory `/build/buildd/monotone-1.0'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/build/buildd/monotone-1.0'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/build/buildd/monotone-1.0'
dh_auto_build: make -j1 INFO_DEPS= returned exit code 2
make[1]: *** [override_dh_auto_build] Error 2
make[1]: Leaving directory `/build/buildd/monotone-1.0'
make: *** [binary] Error 2
dpkg-buildpackage: error: /usr/bin/fakeroot debian/rules binary gave error exit status 2
******************************************************************************
Build finished at 20120208-1656
FAILED [dpkg-buildpackage died]

The full buidlog can be found at https://launchpad.net/ubuntu/+archive/test-rebuild-20120201/+build/3162475/+files/buildlog_ubuntu-precise-i386.monotone_1.0-3_FAILEDTOBUILD.txt.gz.

[1] http://people.ubuntuwire.org/~wgrant/rebuild-ftbfs-test/test-rebuild-20120201-precise.html

[Reinhard Tartler (siretart)]

cf bug 935540

since glibc 2.14, the struct file_handle is taken, and applications must no longer use it.

[Francis Russell (francis-russell)]

I've filed this bug upstream here https://code.monotone.ca/p/monotone/issues/203/

[Francis Russell (francis-russell)]

So, the issue is apparently already fixed in upstream development by the following commit:

https://code.monotone.ca/p/monotone/source/commit/da62cad10eda55aa233ac124273f3db4f541137a/

So either that can be used to build a patch, or if people prefer I could have a go at getting a version with this patch applied into Debian unstable then file a sync request.

[Andreas Moog (ampelbein)]

Francis,

thanks for your research. I think for precise the best way to go is to prepare a upload with the upstream commit applied, and target a new upstream for precise+1. Do you want to go and prepare a 1.0-3ubuntu1 version?

Cheers,

 Andreas

[Francis Russell (francis-russell)]

Certainly. Can you point me to an appropriate wiki page telling me where/how to upload a revised version? From your last messafe, I assume it should be numbered 1.0-3ubuntu1 but I've noticed different numbering conventions on whether the fix is confirmed valid, etc.

[Francis Russell (francis-russell)]

My last message didn't get a reply, so I've prepared a debdiff against the package currently in precise. It incorporates the name clash fix, as well as one for building with the -Werror=format-security flag which I believe may occur under Ubuntu.

[Francis Russell (francis-russell)]

Debdiff attached to this comment. Unfortunately, I don't have a "precise" system to verify compilation on.

[Launchpad Janitor (janitor)]

[Expired for monotone (Ubuntu) because there has been no activity for 60 days.]

[Launchpad Janitor (janitor)]

[Expired for monotone (Ubuntu Precise) because there has been no activity for 60 days.]