Volume Types API doesn't return data correctly

Bug #934435 reported by Chuck Thier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Brian Waldon

Bug Description

The Volume Types API doesn't return data in a way that is consistent with the rest of the OpenStack APIs.

For example when you get a listing, you should get something like:

{"volume_types": [{"id": "1", "name": "vtype"},...]}

But instead you get something like this:

{"vtype": {"id": "1", "name": "vtype"}, ....}

This needs to be corrected so that the volume API is consistent for all of the volume type api calls

Tags: volume
Revision history for this message
Chuck Thier (cthier) wrote :

After inspecting a bit more, it looks like only the listing of volume types isn't correctly formatted. Getting a specific volume type, and creating return the data correctly.

Revision history for this message
clayg (clay-gerrard) wrote :

patch seems to work for me on json and xml

...no tests, sry

Brian Waldon (bcwaldon)
Changed in nova:
assignee: nobody → Brian Waldon (bcwaldon)
importance: Undecided → High
milestone: none → essex-4
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/4361

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/4361
Committed: http://github.com/openstack/nova/commit/47da3250da90bb960b310dc85f60e850979fe3fe
Submitter: Jenkins
Branch: master

commit 47da3250da90bb960b310dc85f60e850979fe3fe
Author: Brian Waldon <email address hidden>
Date: Tue Feb 21 12:06:44 2012 -0800

    Alter output format of volume types resources

    * volumes types lists now fit in with the rest of our API
    * Fixes bug 934435

    Change-Id: Ia67318be363230fcb2819c0df976b44f19dd0876

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.