adding a security rule for ICMP requires a port

[Christian Berendt]

trying to add a security rule for ICMP gives me an error that the fields "From port" and "To port" are required.

[Christian Berendt (berendt)]

Only -1:-1 as ports for ICMP seems to create a usable security rule for ICMP. That's a little bit confusing.

[Tihomir Trifonov (ttrifonov)]

In addition, as seen in nova

https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/contrib/security_groups.py:

            # Verify ICMP type and code
            if (ip_protocol.upper() == "ICMP" and
                (from_port < -1 or to_port > 255)):
                raise exception.InvalidPortRange(from_port=from_port,
                      to_port=to_port, msg="For ICMP, the"
                                           " type:code must be valid")

For ICMP from_port/to_port have different meaning of "type:code". This should be properly exposed in the 'create rule' form with validation and/or help text.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/4346

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/4346
Committed: http://github.com/openstack/horizon/commit/404bda32b95c0f4154378e8f7281ab64c3a5bcfa
Submitter: Jenkins
Branch: master

commit 404bda32b95c0f4154378e8f7281ab64c3a5bcfa
Author: Tihomir Trifonov <email address hidden>
Date: Tue Feb 21 11:15:54 2012 +0200

    Help texts and dynamic label change for entering
    security group rules. ICMP rules have different
    meanings for the from_port and to_port fields.

    Fixes bug 933636

    Patch Set 3: fixed type cast in unit tests

    Change-Id: I745846a0fb054eb03efae102b40428889baed48f