glance xenserver plugin doesn't always retry

[Johannes Erdfelt]

The log on the dom0 will show something like this:

Feb 15 17:14:28 localhost glance: INFO Downloading http://10.x.y.z:9292/v1/images/437c0a22-2a92-448c-bd7b-124fe3976d7f
Feb 15 17:14:28 localhost glance: INFO Reading image data from http://10.x.y.z:9292/v1/images/437c0a22-2a92-448c-bd7b-124fe3976d7f
Feb 15 17:14:29 localhost glance: INFO Read 1441792 bytes from http://10.x.y.z:9292/v1/images/437c0a22-2a92-448c-bd7b-124fe3976d7f
Feb 15 17:14:29 localhost glance: ERROR Downloading http://10.x.y.z:9292/v1/images/437c0a22-2a92-448c-bd7b-124fe3976d7f attempt 1 error: 'tar -zx --directory=/var/run/sr-mount/10f0f335-43d4-edd2-7abe-bc1dca7f2ac7/tmp7lwYp4' returned non-zero exit code: retcode=2, stderr=' gzip: stdin: unexpected end of file tar: Unexpected EOF in archive tar: Unexpected EOF in archive tar: Error is not recoverable: exiting now '

and then this will be seen on the compute node:

(nova.rpc): TRACE: Failure: ['XENAPI_PLUGIN_FAILURE', 'download_vhd', 'BadStatusLine', '']

The glance plugin will attempt to reuse a urllib2 request on a connection in an unknown state. This can lead to a BadStatusLine error.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/4207

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/4207
Committed: http://github.com/openstack/nova/commit/3a95d451edfa622b987cdc8f904cd00262f32cea
Submitter: Jenkins
Branch: master

commit 3a95d451edfa622b987cdc8f904cd00262f32cea
Author: Johannes Erdfelt <email address hidden>
Date: Wed Feb 15 17:38:05 2012 +0000

    Catch httplib.HTTPException as well

    Fixes bug 932927

    None of the httplib exceptions will get converted into urllib2 exceptions

    Change-Id: Iad72821fa1ed54fdb213b371223e94e183dec334