Able to open multiple "Remove All Graphs" and "Change Graph Size" windows in dashboard

[Daniel Lawrence]

Because the "Remove All Graphs" and "Change Graph Size" windows do not mask everything behind it when displayed. It allows the user to open many of the same window all at once.

http://www.danielscottlawrence.com/wp-content/uploads/2012/02/without-modal.png

However by adding the modal flag to the windows it masks out all the background ui until the window is closed. This is the same as all the other pop-up windows in the dash board. Resulting the the below screenshot from opening the "Change Graph Size" window.

http://www.danielscottlawrence.com/wp-content/uploads/2012/02/with-modal.png

The below adds the modal option ( http://docs.sencha.com/ext-js/4-0/#!/api/Ext.window.Window-cfg-modal
 ) and sets it to true for both the windows.

[Nicholas Leskiw (nleskiw)]

Does this affect the ability to use "Graph Options" and "Graph Data" at the same time (does the window have focus until it is closed?).

-Nick

On Feb 13, 2012, at 6:01 AM, Daniel Lawrence <email address hidden> wrote:

> Public bug reported:
>
> Because the "Remove All Graphs" and "Change Graph Size" windows do not
> mask everything behind it when displayed. It allows the user to open
> many of the same window all at once.
>
> http://www.danielscottlawrence.com/wp-content/uploads/2012/02/without-
> modal.png
>
> However by adding the modal flag to the windows it masks out all the
> background ui until the window is closed. This is the same as all the
> other pop-up windows in the dash board. Resulting the the below
> screenshot from opening the "Change Graph Size" window.
>
> http://www.danielscottlawrence.com/wp-content/uploads/2012/02/with-
> modal.png
>
>
> The below adds the modal option ( http://docs.sencha.com/ext-js/4-0/#!/api/Ext.window.Window-cfg-modal
> ) and sets it to true for both the windows.
>
> ** Affects: graphite
> Importance: Undecided
> Status: New
>
>
> ** Tags: dashboard
>
> --
> You received this bug notification because you are subscribed to
> Graphite.
> https://bugs.launchpad.net/bugs/931401
>
> Title:
> Able to open multiple "Remove All Graphs" and "Change Graph Size"
> windows in dashboard
>
> Status in Graphite - Enterprise scalable realtime graphing:
> New
>
> Bug description:
> Because the "Remove All Graphs" and "Change Graph Size" windows do not
> mask everything behind it when displayed. It allows the user to open
> many of the same window all at once.
>
> http://www.danielscottlawrence.com/wp-content/uploads/2012/02/without-
> modal.png
>
> However by adding the modal flag to the windows it masks out all the
> background ui until the window is closed. This is the same as all the
> other pop-up windows in the dash board. Resulting the the below
> screenshot from opening the "Change Graph Size" window.
>
> http://www.danielscottlawrence.com/wp-content/uploads/2012/02/with-
> modal.png
>
>
> The below adds the modal option ( http://docs.sencha.com/ext-js/4-0/#!/api/Ext.window.Window-cfg-modal
> ) and sets it to true for both the windows.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/graphite/+bug/931401/+subscriptions

[Daniel Lawrence (dannyla)]

Yes, as it masks out the rest of the UI you can't use the same windows at the same time.
In the same way that you can't use the "Dashboard Finder" and the "Keyboard shortcuts" window at the same time.

[Michael Leinartas (mleinartas)]

Thanks for the patch, committed this in r756.