Remove redundant code from resolvconf postinst
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
resolvconf (Ubuntu) |
Fix Released
|
Low
|
Unassigned |
Bug Description
For earlier discussion please see #929552.
Resolvconf preinst has to create run-time directories. Resolvconf postinst has to enable updates. (They of course do other things which aren't relevant here.)
Resolvconf's Upstart job does both; /etc/init/
[...]
start on mounted MOUNTPOINT=/run
pre-start script
mkdir -p /run/resolvconf
touch /run/resolvconf
resolvconf --enable-updates
end script
[...]
Now, resolvconf postinst runs the Upstart job by means of
invoke-rc.d resolvconf start
where /etc/init.
Because resolvconf postinst runs the upstart job which enables updates it is not necessary for the postinst to enable updates itself. Currently it does so by triggering itself and enabling updates when "$1" = triggered. The section of the postinst that does this is redundant and should be removed. See attachment for patch. The file debian/triggers should also be removed.
(Background: In Debian, resolvconf.postinst triggers itself and only enables updates in the "triggered" phase; this avoid redundant update runs when resolvconf is installed along with packages whose postinsts induce resolvconf-
--
Thomas Hood
Changed in resolvconf (Ubuntu): | |
status: | New → Incomplete |
status: | Incomplete → Triaged |
importance: | Undecided → Low |
The attachment "resolvconf- postinst- deredundantify_ 20120213th1. diff" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.
[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]