pep8 validation on all xapi plugins

Bug #929428 reported by Armando Migliaccio
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
simon bellenger

Bug Description

Extend pep8 check on all the xapi plugins, not just 'glance'.

function run_pep8 {
  echo "Running pep8 ..."
  # Opt-out files from pep8
  ignore_scripts="*.sh:*nova-debug:*clean-vlans"
  ignore_files="*eventlet-patch:*pip-requires"
  GLOBIGNORE="$ignore_scripts:$ignore_files"
  srcfiles=`find bin -type f ! -name "nova.conf*" ! -name "api-paste.ini*"`
  srcfiles+=" `find tools/*`"
  srcfiles+=" nova setup.py plugins/xenserver/xenapi/etc/xapi.d/plugins/glance"
  # Just run PEP8 in current environment
...

Changed in nova:
status: New → Confirmed
assignee: nobody → Armando Migliaccio (armando-migliaccio)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/3957

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/3957
Committed: http://github.com/openstack/nova/commit/61e6f4e34aebdcc79d377fafede563dbd9e63019
Submitter: Jenkins
Branch: master

commit 61e6f4e34aebdcc79d377fafede563dbd9e63019
Author: Armando Migliaccio <email address hidden>
Date: Thu Feb 9 10:32:24 2012 +0000

    bug 929428: pep8 validation on all xapi plugins

    check every python file under <nova_root>/plugins/xenserver/.
    Ignore patch files.

    Change-Id: Ib1170ddabe03de746aae570d30b133aaffb09c88

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-4
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-4 → 2012.1
Changed in nova:
assignee: Armando Migliaccio (armando-migliaccio) → simon bellenger (sjbellenger)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.