add unit test to check for plurals in routes

Bug #927879 reported by Joseph Heck
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Wishlist
David Ripton

Bug Description

wishlist item (simple, low-hanging-fruit)

this is maybe meta, but if anybody wants to back-burner it, i'd love for some sort of check in the tests that checks for the word "condition" instead of "conditions" in any of the routes calls and "methods" instead of "method" in the same call

we've been bit multiple times already by forgetting which one is plural and not checking

it is small though, just would be a nice regex for somebody

David Ripton (dripton)
Changed in keystone:
assignee: nobody → David Ripton (dripton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/14298

Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/14298
Committed: http://github.com/openstack/keystone/commit/fa98220aac1876468f595f4842edf4f682a6db1a
Submitter: Jenkins
Branch: master

commit fa98220aac1876468f595f4842edf4f682a6db1a
Author: David Ripton <email address hidden>
Date: Wed Oct 10 13:06:10 2012 -0400

    Raise if we see incorrect keyword args "condition" or "methods"

    Fixes bug 927879

    We crawl the AST of the set of modules that make routing calls, looking
    for keyword arguments called "condition" (should be "conditions") or
    "methods" (should be "method"), and raise if we see any.

    Change-Id: I32aa140967b80d83a10db898df28e41189675d77

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: grizzly-1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.