Backslash continuations

Bug #925166 reported by Kevin L. Mitchell
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Wishlist
Zhongyue Luo

Bug Description

There are several places in nova where we make use of backslash continuations. However, this is discouraged by PEP8. Not all of these places are avoidable, e.g., some of the SQLAlchemy query construction calls or the mox calls, or certain assignments—but many of these are, through judicious use of parentheses. (In some places, the parentheses, brackets, or braces may even already exist!) We should clean these up throughout nova.

Brian Waldon (bcwaldon)
Changed in nova:
status: New → Triaged
importance: Low → Wishlist
Revision history for this message
Zhongyue Luo (zyluo) wrote :

There are 941 lines which use backslash continuations.

Changed in nova:
assignee: nobody → Zhongyue Luo (lzyeval)
Revision history for this message
Zhongyue Luo (zyluo) wrote :

I'll split this bug report into units of packages

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/3652

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/3652
Committed: http://github.com/openstack/nova/commit/525ba40417256f6448c52939274ee2505fbc6b78
Submitter: Jenkins
Branch: master

commit 525ba40417256f6448c52939274ee2505fbc6b78
Author: Zhongyue Luo <email address hidden>
Date: Thu Feb 2 14:15:39 2012 +0900

    Backslash continuations (misc.)

    Fixes bug #925166

    This patch for packages which have few backslash continuations.

    Follow up patches will be for packages network, scheduler, virt,
    db/sqlalchemy, tests, and api/openstack.

    Change-Id: I4200010b47b33fa8b9115b5d379b543200f6668d

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-4
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.