pkgstripfiles: md5sum incorrect when advpng fails
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
pkgbinarymangler (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The md5sum is not updated when advpng fails but optipng ran fine.
This happened with the gquilt 0.25-2 package:
Unexpected PLTE chunk on ./usr/share/
WARNING: advpng failed on ./usr/share/
Then lintian says:
E: gquilt: md5sum-mismatch usr/share/
> if ! optipng -o4 -preserve "$f"; then
> echo "WARNING: optipng failed on $f, ignoring" >&2
> continue
> fi
> if ! advpng -z4 "$f"; then
> echo "WARNING: advpng failed on $f, ignoring" >&2
> continue
> fi
The second continue statement needs to be removed.
I'm not sure why the first one is there, mabye both should be removed.
Thanks! Indeed they should both be removed, there is no reason that advpng should be skipped if optipng fails.