admin GET on /servers should NOT return servers for all tenants

[Dan Prince]

By default, if you are an admin user and you perform a GET on /servers it will return a list of servers for all tenants (projects) in the system regardless of the tenant_id used in the URL.

This is problematic and can lead to confusion if a tenant alternate tenant ID is specified in the URL. This could be easily accomplished with bindings, novaclient, etc.

To reproduce do something like this...

1) Setup an installation with multiple users. One should be an adminstrator. The other can be a regular user.

2) Create servers in both accounts.

3) Configure novarc so that it uses the admin credentials /w the tenant ID of the normal user.

4) Do another 'nova list' and notice that servers for all tenants are still returned.

---

I'd like to see us add an 'all_tenants' filter option to the API so that we can maintain the existing behavior for OPS team members. This provides them the ability to search and query servers from multiple tenants from a single account.

However if the 'all_tenants' option isn't used we should restrain the API to the tenant_id that was specified in the URL.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/3531

[Dan Prince (dan-prince)]

See this related ticket for an associated novaclient change...

https://bugs.launchpad.net/nova/+bug/916219

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/3531
Committed: http://github.com/openstack/nova/commit/6e35b5785d12513dc0076145f4de5e1f98034250
Submitter: Jenkins
Branch: master

commit 6e35b5785d12513dc0076145f4de5e1f98034250
Author: Dan Prince <email address hidden>
Date: Sat Jan 28 22:52:29 2012 -0500

    Add 'all_tenants' filter to GET /servers.

    Update the OpenStack API's GET /servers method so that it only returns
    servers from a single tenant when an admin account is used.

    Adds an 'all_tenants' filter option that can be used to obtain servers
    from all tenants (legacy behavior).

    Fixes LP Bug # 923218.

    Change-Id: I2fd3bd3e2c374ff1aed9c11006585c3f93449c6e