All debug log entries end in same source code and line

[Jay Pipes]

The introspection of the originating source code line for DEBUG log messages is useless, as it always indicates the source code line for the log.debug():

2012-01-23 22:37:21,324 DEBUG nova.utils [-] Attempting to grab semaphore "iptables" for method "apply"... from (pid=9163) debug /opt/stack/nova/nova/log.py:175
2012-01-23 22:37:21,324 DEBUG nova.utils [-] Got semaphore "iptables" for method "apply"... from (pid=9163) debug /opt/stack/nova/nova/log.py:175
2012-01-23 22:37:21,324 DEBUG nova.utils [-] Attempting to grab file lock "iptables" for method "apply"... from (pid=9163) debug /opt/stack/nova/nova/log.py:175
2012-01-23 22:37:21,325 DEBUG nova.utils [-] Got file lock "iptables" for method "apply"... from (pid=9163) debug /opt/stack/nova/nova/log.py:175
2012-01-23 22:37:21,325 DEBUG nova.utils [-] Running cmd (subprocess): sudo iptables-save -t filter from (pid=9163) debug /opt/stack/nova/nova/log.py:175

Every single DEBUG line ends this way...

[Alex Meade (alex-meade)]

The issue is that logging gets the current stack frame and then goes back to the previous one to get the information about what called the log method. Since this is the case, we cannot add any more calls to the stack between the calling of log.debug and it's calling of log._log.

At the moment we have one in the middle, I'll have a MP in a min to fix this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/3634

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/3634
Committed: http://github.com/openstack/nova/commit/84cf57fde657eb4146442047a565fd7087bce345
Submitter: Jenkins
Branch: master

commit 84cf57fde657eb4146442047a565fd7087bce345
Author: Alex Meade <email address hidden>
Date: Wed Feb 1 20:35:50 2012 +0000

    Fix logging to log correct filename and line numbers

    Fixes bug 920809.

    Change-Id: I192159efbb8d678d1e1071b18233d19ebcd7198b