Add the group category filter to /admin/groups/groups.php

[Kristina Hoeppner]

affects Mahara 1.4, master

The "Administer Groups" page /admin/groups/groups.php could have the category filter like the "My Groups" /group/mygroups.php and "Find Groups" pages to easily filter groups according to a category instead of guessing the writing of it.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10054

[Steven (stevens-q)]

 Commit hash: a964a79c19e4e45a729600e42b3ec1abca496b66
Environment tested: Master
Browser tested: Chrome
Theme used: Raw | Default raw | Ocean | Modern | Primary school

PRECONDITIONS:
------------------------
1) Site settings are set to allow Groups to use Categories (admin menu > Configure site > Site options > Group settings)
2) Groups exist as follows
    a) Really long Group Name - (category = Computers & Tech)
    b) Group One (category = Finance)
3) The following Group Categories exist
    a) Computers & Tech
    b) Finance

TEST STEPS:
------------------------
1) Log in as Site admin
2) Browse to admin menu > Groups > Administer groups
3) Verify that the Table listing the Groups has the following columns
   a) GROUP NAME
   b) SHORT NAME
   c) MEMBERS
   d) ADMINISTRATORS
   e) GROUP TYPE
   f) GROUP CATEGORY
   g) VISIBILITY
   h) INSTITUTION
4) Verify that the icon buttons for the following are displayed
   a) Manage
   b) Export group membership in CSV format for "Group Name"
   c) Copy group "Alice's Group"
   d) Delete

Display Issues

1) Although functionality is working, the columns are not distributed very well. The left side of table seems sparse while the right side of the table is too close together. - Recommend - spacing the colums better
2) When the names are too long for the column, The line break should not be in mid word but rather break at the end of the word

[Steven (stevens-q)]

Commit hash: 7e8192ce230b8afecba5341917598b171a8a7ccc
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) Site settings are set to allow Groups to use Categories (admin menu > Configure site > Site options > Group settings)
2) Groups exist as follows
a) Really long Group Name - (category = Computers & Tech)
b) Group One (category = Finance)
3) The following Group Categories exist
a) Computers & Tech
 b) Finance

TEST STEPS:
------------------------
1) Log in as Site admin
2) Browse to admin menu > Groups > Administer groups
3) Verify that the Table listing the Groups has the following columns ✔
   a) GROUP NAME ✔
   b) SHORT NAME ✔
   c) MEMBERS ✔
   d) ADMINISTRATORS ✔
   e) GROUP TYPE ✔
   f) GROUP CATEGORY ✔
   g) VISIBILITY ✔
   h) INSTITUTION ✔
4) Verify that the icon buttons for the following are displayed
   a) Manage ✔
   b) Export group membership in CSV format for "Group Name" ✔
   c) Copy group "Alice's Group" ✔
   d) Delete ✔
5) Verify the columns are distributed evenly ✔
6) Verify the line break should not be in mid word but rather break at the end of the word ✔
7) Verify that the pagination is working as expected when there are more than 10 groups displayed in the results table
8) Verify the Results per page functionality is working when there are more than 10 groups displayed in the results table

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10054
Committed: https://git.mahara.org/mahara/mahara/commit/c541934b2486210572edb2e60fe9bf7bb5bcedec
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c541934b2486210572edb2e60fe9bf7bb5bcedec
Author: Doris Tam <email address hidden>
Date: Wed May 29 14:39:10 2019 +1200

Bug 920246: Adding category filter to admin/groups/groups.php

- Like the group/index.php page with the filter, this page also
has a problem with the button when the width of screen is too small
- Added a parameter to an existing helper function for groupcategory
(build_group_list_html
- Helper function group_get_extended_data(..) to htdocs/lib/group.php
- Fix previous bug failure due to button class change for submit
- Styling for table changed to to "break-word" to stop truncating words
- overflow of buttons controlled + responsive results heading+footer
- button moved to first level of form to stop button cutting button on
small screen
behatnotneeded

Change-Id: I646135f6963f944b6d253d800882a77cac995e1a