Copying a box-selected pin only copies visible attributes

[Gareth Edwards]

Bug found in current git stable-1.8.

Steps to reproduce:

- $ gschem test.sym
- close the erroneous error dialog
- create a pins
- box select the pin with a drag of the mouse. Do not click-select.
- using the context menu, copy the pin to another location on the sheet.
- Look at the attributes of the copied pin. Only the visible attributes (pinlabel, pinnumber) are copied. pinseq and pintype are not copied.

[Nathan Schulte (nmschulte)]

I can reproduce this issue. I've also narrowed the cause; this is a regression caused by commit 97bea3a, which closes bug 912475; marking it confirmed.

[Nathan Schulte (nmschulte)]

The attached patch fixes this bug by always selecting invisible (hidden) attributes for an object, even if it was selected via the select box.

This has the implication that if a visible attribute is not selected during a copy/move/..., that attribute will be left out of the operation. I believe this to be intended behavior, however.

[Nathan Schulte (nmschulte)]

Here is a patch with some code style and formatting changes I made while researching this bug. This patch is against the previous submitted patch, but should apply straight onto head without modification.

[gpleda.org commit robot (gpleda-launchpad-robot)]

A commit was made which affects this bug
git stable-1.8 commit 037b21c18cb674ac50970e8474138b6809d3fcb6
http://git.gpleda.org/?p=gaf.git;a=commit;h=037b21c18cb674ac50970e8474138b6809d3fcb6

commit 037b21c18cb674ac50970e8474138b6809d3fcb6
Author: Nathan Schulte <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Fix formatting and code style

    Affects-bug: lp-916234

[gpleda.org commit robot (gpleda-launchpad-robot)]

Bug was fixed by a commit
git stable-1.8 commit e0140ecc98a57fc480a152717b53ac6fe5463611
http://git.gpleda.org/?p=gaf.git;a=commit;h=e0140ecc98a57fc480a152717b53ac6fe5463611

commit e0140ecc98a57fc480a152717b53ac6fe5463611
Author: Nathan Schulte <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Fix bug with selection and hidden attributes

    Fixes a regression caused by 9b73a4c7f6f5e9dade0ddaca5aadc9ecb326bb5c.
    When selecting an object via box selection it's invisible attributes
    are now automatically selected as well.

    Closes-bug: lp-916234

[gpleda.org commit robot (gpleda-launchpad-robot)]

A commit was made which affects this bug
git master commit 037b21c18cb674ac50970e8474138b6809d3fcb6
http://git.gpleda.org/?p=gaf.git;a=commit;h=037b21c18cb674ac50970e8474138b6809d3fcb6

commit 037b21c18cb674ac50970e8474138b6809d3fcb6
Author: Nathan Schulte <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Fix formatting and code style

    Affects-bug: lp-916234

[gpleda.org commit robot (gpleda-launchpad-robot)]

Bug was fixed by a commit
git master commit e0140ecc98a57fc480a152717b53ac6fe5463611
http://git.gpleda.org/?p=gaf.git;a=commit;h=e0140ecc98a57fc480a152717b53ac6fe5463611

commit e0140ecc98a57fc480a152717b53ac6fe5463611
Author: Nathan Schulte <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Fix bug with selection and hidden attributes

    Fixes a regression caused by 9b73a4c7f6f5e9dade0ddaca5aadc9ecb326bb5c.
    When selecting an object via box selection it's invisible attributes
    are now automatically selected as well.

    Closes-bug: lp-916234