Inverted selection doesn't work properly with attributes

Bug #912475 reported by Nathan Schulte
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
Undecided
Unassigned

Bug Description

When making an inverted selection with the lasso tool on a symbol and some of its attributes, the attributes are doubly invert-selected, causing them to remain unselected. This only occurs for selection and does not apply for deselection.

Invert select clicking (as opposed to lassoing) on a symbol that already has some of its attributes selected is not affected by the issue either.

Tags: gschem
Revision history for this message
Nathan Schulte (nmschulte) wrote :

Discovered by Peter Brett, confirmed by myself.

Changed in geda:
status: New → Confirmed
Revision history for this message
Nathan Schulte (nmschulte) wrote :
Revision history for this message
Nathan Schulte (nmschulte) wrote :

The above patch makes the assumption that when a user tries to select things with a select box, they wish to handle symbols and their attributes independently. It still "does the right thing" regarding hidden attributes and the like.

Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

Bug was fixed by a commit
git stable-1.8 commit 97bea3a73c9c8d25d54454ea28a942b9c9c38c57
http://git.gpleda.org/?p=gaf.git;a=commit;h=97bea3a73c9c8d25d54454ea28a942b9c9c38c57

commit 97bea3a73c9c8d25d54454ea28a942b9c9c38c57
Author: Nathan Schulte <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Fix bug with invert selection and attributes

    This fixes a bug that causes attributes to be left unselected when
    selected in the same select box as their parent object.

    Closes-bug: lp-912475

Changed in geda:
status: Confirmed → Fix Committed
Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

Bug was fixed by a commit
git master commit 97bea3a73c9c8d25d54454ea28a942b9c9c38c57
http://git.gpleda.org/?p=gaf.git;a=commit;h=97bea3a73c9c8d25d54454ea28a942b9c9c38c57

commit 97bea3a73c9c8d25d54454ea28a942b9c9c38c57
Author: Nathan Schulte <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Fix bug with invert selection and attributes

    This fixes a bug that causes attributes to be left unselected when
    selected in the same select box as their parent object.

    Closes-bug: lp-912475

Peter TB Brett (peter-b)
Changed in geda:
milestone: none → 1.8.0
Peter TB Brett (peter-b)
Changed in geda:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.