Allowing auth plugins to provide extra elements and javascript in the login form

[François Marier]

We should not assume that all authentication plugins will be based on the Mahara username/password login form.

Three new API functions are needed:

- whether or not the plugin requires the basic login form elements (username and password fields, login button)
- any extra Javascript to inject in the login form area
- any extra pieforms elements to add to the login form

[François Marier (fmarier)]

Bug 904620 is related to this

[François Marier (fmarier)]

https://reviews.mahara.org/933
https://reviews.mahara.org/934
https://reviews.mahara.org/935
https://reviews.mahara.org/936
https://reviews.mahara.org/937

[Ruslan Kabalin (rkabalin)]

Related discussion: http://mahara.org/interaction/forum/topic.php?id=2602

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/933
Committed: http://gitorious.org/mahara/mahara/commit/8228bbcb8f44d7e029a1038d6511843ee3184d26
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 8228bbcb8f44d7e029a1038d6511843ee3184d26
Author: Francois Marier <email address hidden>
Date: Tue Dec 13 17:36:05 2011 +1300

    Allow auth plugins to provide extra login form javascript

    Some authentication plugins need to inject some more Javascript
    into the login form. This adds a function to the API to enable this.

    Bug #905081

    Change-Id: Icf1018558fe9210261c4f758169fd30afb4f89ab
    Signed-off-by: Francois Marier <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/936
Committed: http://gitorious.org/mahara/mahara/commit/86738f26b43a04b8b4e606a659aeecfead45e7e2
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 86738f26b43a04b8b4e606a659aeecfead45e7e2
Author: Francois Marier <email address hidden>
Date: Fri Dec 16 15:13:40 2011 +1300

    Make the basic login form optional

    By default the login form is needed by every auth plugin however
    they can now override this and state that it's not needed.

    If there are no usabled/enabled auth plugins that need the standard
    username/password login form, then it is no longer displayed.

    Note that until bug 904620 is fixed, you cannot remove the Internal
    auth plugin (which needs the basic form elements) without a bit of
    database surgery.

    Bug #905081

    Change-Id: If2bc7510a93e3aa365c41b4e3d7f6c3ce782d4c1
    Signed-off-by: Francois Marier <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/937
Committed: http://gitorious.org/mahara/mahara/commit/48a085faa8707c970b6f39b8565e35228f881873
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 48a085faa8707c970b6f39b8565e35228f881873
Author: Francois Marier <email address hidden>
Date: Fri Dec 16 15:14:12 2011 +1300

    SAML: make basic login form optional (bug #905081)

    Change-Id: I156e75f5d8df811932493b83df20f82fd5c4550c
    Signed-off-by: Francois Marier <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/935
Committed: http://gitorious.org/mahara/mahara/commit/32e74e1bc8ab28bb458868c62690a33397fe6fb5
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 32e74e1bc8ab28bb458868c62690a33397fe6fb5
Author: Francois Marier <email address hidden>
Date: Thu Dec 15 19:20:57 2011 +1300

    Move the SAML "SSO Login" link to PluginAuthSaml

    The query is no longer needed since that login_form_elements()
    function will only get called if there is a usable and enabled
    SAML auth instance somewhere.

    Bug #905081

    Change-Id: Ia68d968baad17a22957e2e43e98a430eae201347
    Signed-off-by: Francois Marier <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/934
Committed: http://gitorious.org/mahara/mahara/commit/c40b75f6f35f581356f180c7337134d9f70445f9
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit c40b75f6f35f581356f180c7337134d9f70445f9
Author: Francois Marier <email address hidden>
Date: Wed Dec 14 19:25:14 2011 +1300

    Enable auth plugins to supply extra login form elements

    This will ensure that we don't need to hack core to add links to
    the bottom of the main login form for example.

    Bug #905081

    Change-Id: I44d1b335660dda89c55e2cdee1cd7b59484accfe
    Signed-off-by: Francois Marier <email address hidden>

[Melissa Draper (melissa)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjrZVAAoJECXBtiziiXdcS3oIAJgrwXm2JGD/y1azBwhHoMLL
x7gg30QpnnlKu2Cnz9FQBBNXS3c3avtDysNR6UAmXmtO4IHvrcl8QZB4NP2j31Qd
WbtmXSjKFijA1wGhqhIJXrRxTDZQBEHNLIRnIUIPqny+YRJtqHIR3a5rSRYUEiiR
UreRpHjMubPyNKbJSHclRKK4LzOZAng7c8CwL0f+y1GnmUoFVy8gZweasWtq0pwk
XWHYlOxf+i11rrEyV3abVFsWGn/F7Fj2uI00V3E5U/15cYb0+WQ9eiSDnDpKC7l0
QvcNHx6w9vuN21ROyjBrOfhfD+s6aBow046EMBpR7SFbR7vCOdxwxh4WYcqIKVM=
=bsqZ
-----END PGP SIGNATURE-----