NumberRate skin definitions are not hooked up to rate_dir and rateRange.

[RJ Skerry-Ryan]

If rate range or direction changes, the text does not immediately update. It needs a movement of the rate slider to trigger a refresh. This could be fixed via two ways:

1) Update skin.xml to include
<Connection>
  <ConfigKey>[...],rate_dir</ConfigKey>
</Connection>
<Connection>
  <ConfigKey>[...],rateRange</ConfigKey>
</Connection>

Connections on all NumberRate controls.

2) Update WNumberRate code to make these connections automatically and remove all <Connection> blocks from <NumberRate> elements in all skin.xml's

I'm partial to solution 2 since the NumberRate widgets already hard-code their use of the rate COs.

[jus (jus)]

I think solution #2 is the better one, but how does this change affect users with older custom skins that may still have the <Connection> blocks ?

[RJ Skerry-Ryan (rryan)]

If the connection block is removed it will cause the rate text to not
update at all if a new skin is used in an old Mixxx.

On Mon, Dec 12, 2011 at 2:17 PM, jus <email address hidden> wrote:

> I think solution #2 is the better one, but how does this change affect
> users with older custom skins that may still have the <Connection>
> blocks ?
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/903316
>
> Title:
> NumberRate skin definitions are not hooked up to rate_dir and
> rateRange.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/903316/+subscriptions
>

[jus (jus)]

Patch removes remove all <Connection> blocks from <NumberRate> elements in skin.xml's as required by solution #2
Patch is against latest http://bazaar.launchpad.net/~mixxxdevelopers/mixxx/release-1.10.x/revision/2986

[jus (jus)]

Oops, maybe i was a little too fast with marking fix committed.
With the latest patch from http://bazaar.launchpad.net/~mixxxdevelopers/mixxx/release-1.10.x/revision/2987 the <NumberRate> display is now blank on startup or on skin change. If triggered by slider/button movement the pitch rate is displayed.

Also the <NumberRate> display is always set to "+0.00" on range changes like it was before the patch . On direction changes the <NumberRate> display does update immediately now.

[RJ Skerry-Ryan (rryan)]

Good catch -- fixed now.

[RJ Skerry-Ryan (rryan)]

Changes to the rate range via the Interface preference page does reset the rate slider to its center position, so resetting to +0.00 is simply reflecting that change. I believe the reset of the rate slider to its center position was intended, though I don't know who originally added that behavior.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6177