lucid->precise upgrade - prompt to update unmodified conf file: /etc/init/failsafe-x.conf

[Jean-Baptiste Lallement]

Autoupgrade testing Lucid to Precise desktop i386/amd64

The base image is a fresh installation of Lucid. During upgrade, the user is prompted to update the following unmodified configuration file:
/etc/init/failsafe-x.conf

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: xdiagnose 1.8
ProcVersionSignature: Ubuntu 3.2.0-3.8-generic 3.2.0-rc4
Uname: Linux 3.2.0-3-generic x86_64
.tmp.unity.support.test.0:

ApportVersion: 1.90-0ubuntu1
Architecture: amd64
CompizPlugins: [core,bailer,detection,composite,opengl,decor,mousepoll,vpswitch,regex,animation,snap,expo,move,compiztoolbox,place,grid,imgpng,gnomecompat,wall,ezoom,workarounds,resize,fade,unitymtgrabhandles,scale,session,unityshell]
CompositorRunning: compiz
Date: Mon Dec 12 12:03:18 2011
DistUpgraded: Fresh install
DistroCodename: precise
DistroVariant: ubuntu
DkmsStatus:
 virtualbox, 4.1.6, 3.2.0-1-generic, x86_64: installed
 virtualbox, 4.1.6, 3.2.0-2-generic, x86_64: installed
 virtualbox, 4.1.6, 3.2.0-3-generic, x86_64: installed
EcryptfsInUse: Yes
GraphicsCard:
 Intel Corporation Core Processor Integrated Graphics Controller [8086:0046] (rev 18) (prog-if 00 [VGA controller])
   Subsystem: Dell Device [1028:0456]
InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Release amd64 (20111012)
MachineType: Dell Inc. Inspiron N4010
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.utf8
 SHELL=/bin/bash
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.2.0-3-generic root=UUID=d8966312-304d-4504-b854-5ec365ce6e20 ro quiet splash vt.handoff=7
SourcePackage: xdiagnose
UpgradeStatus: No upgrade log present (probably fresh install)
dmi.bios.date: 01/19/2011
dmi.bios.vendor: Dell Inc.
dmi.bios.version: A11
dmi.board.name: 021CN3
dmi.board.vendor: Dell Inc.
dmi.board.version: A11
dmi.chassis.type: 8
dmi.chassis.vendor: Dell Inc.
dmi.chassis.version: A11
dmi.modalias: dmi:bvnDellInc.:bvrA11:bd01/19/2011:svnDellInc.:pnInspironN4010:pvrA11:rvnDellInc.:rn021CN3:rvrA11:cvnDellInc.:ct8:cvrA11:
dmi.product.name: Inspiron N4010
dmi.product.version: A11
dmi.sys.vendor: Dell Inc.
version.compiz: compiz 1:0.9.6+bzr20110929-0ubuntu8
version.ia32-libs: ia32-libs N/A
version.libdrm2: libdrm2 2.4.27-1ubuntu1
version.libgl1-mesa-dri: libgl1-mesa-dri 7.11-0ubuntu4
version.libgl1-mesa-dri-experimental: libgl1-mesa-dri-experimental N/A
version.libgl1-mesa-glx: libgl1-mesa-glx 7.11-0ubuntu4
version.xserver-xorg-core: xserver-xorg-core 2:1.10.4-1ubuntu6
version.xserver-xorg-input-evdev: xserver-xorg-input-evdev 1:2.6.0-1ubuntu13
version.xserver-xorg-video-ati: xserver-xorg-video-ati 1:6.14.99~git20110811.g93fc084-0ubuntu1
version.xserver-xorg-video-intel: xserver-xorg-video-intel 2:2.15.901-1ubuntu4
version.xserver-xorg-video-nouveau: xserver-xorg-video-nouveau 1:0.0.16+git20110411+8378443-1

[Martin Pitt (pitti)]

Handing to Bryce as this is his project. Bryce, please let me know if you need some hand with this, as conffile handling is a bit special. Thanks!

[Steve Langasek (vorlon)]

Please see bug #903137 and bug #903131. There seems to be some systemic problem affecting conffile handling in the upgrade tests which has not been reported elsewhere; xdiagnose already has the correct versioned Replaces: on x11-common that should allow a smooth upgrade with no prompts, so the problem does not look like a bug in xdiagnose.

[Martin Pitt (pitti)]

I cannot reproduce this with doing a (partial) lucid->precise upgrade in a lucid live system. However, I think I see one thing which could go wrong:

/var/lib/dpkg/info/x11-common.preinst correctly does

   if dpkg --compare-versions "$2" lt-nl "1:7.6+7ubuntu7"; then
    remove_conffile_lookup x11-common "/etc/init/failsafe-x.conf"
  fi

to clean up its own old conffile, so that xdiagnose can put its own. xdiagnose also Replaces: x11-common (<< 1:7.6+7ubuntu1), but that doesn't prevent xdiagnose from being unpacked before x11-common is upgraded. So I think xdiagnose should grow a

  Conflicts: x11-common (<< 1:7.6+7ubuntu1)

to ensure that x11-common gets upgraded before xdiagnose gets installed. This should make sure that there is no conffile prompt.

[Martin Pitt (pitti)]

It seems Bryce is on holiday, I'll just take this.

[Launchpad Janitor (janitor)]

This bug was fixed in the package xdiagnose - 1.9

---------------
xdiagnose (1.9) precise; urgency=low

  * debian/control: Add versioned Conflicts: to x11-common, to ensure that we
    don't unpack xdiagnose with a changed /etc/init/failsafe-x.conf conffile
    before the new x11-common preinst has a chance to remove its own obsolete
    one. (LP: #903143)
 -- Martin Pitt <email address hidden> Thu, 15 Dec 2011 10:31:58 +0100