gnome-control-center Keyboard Layout and User Accounts modules crash under IceWM

[Bela Lubkin]

Ubuntu 11.10 patched to the minute with oneiric-proposed
Specifically, gnome-control-center 1:3.2.2-0ubuntu1; icewm 1.3.7-1

Cause: IceWM does not set environment variable $XDG_CURRENT_DESKTOP;
gnome-control-center relies on this variable to be set. Crash happens because
it tries to dereference a null pointer returned by getenv().

The bug (actually two bugs) is introduced by the Ubuntu patches 10_keyboard_layout_on_unity.patch and 53_use_ubuntu_help.patch.

TO REPRODUCE under any window manager:

   $ env -u XDG_CURRENT_DESKTOP gnome-control-center
   [ click on Keyboard Layout ]
   [ OR click on Keyboard, then Layout Settings ]
   [ OR click on User Accounts ]

Patch attached. The patch makes gnome-control-center treat a missing
$XDG_CURRENT_DESKTOP the same as an empty value.

[Bela Lubkin (filbo)]

(See also https://bugzilla.gnome.org/show_bug.cgi?id=665947 -- retracted when I realized the bug was in Ubuntu)

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "harden against unset XDG_CURRENT_DESKTOP" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-control-center - 1:3.2.2-0ubuntu5

---------------
gnome-control-center (1:3.2.2-0ubuntu5) precise; urgency=low

  * debian/patches/10_keyboard_layout_on_unity.patch,
    debian/patches/53_use_ubuntu_help.patch:
    - handle cases where XDG_CURRENT_DESKTOP is not set
      (i.e users not using gnome-session) (lp: #902780)
 -- Sebastien Bacher <email address hidden> Wed, 14 Dec 2011 16:40:27 +0100

[Sebastien Bacher (seb128)]

Thank you for your bug report and work, I've fixed the issue differently just using g_strcmp0 which handles null arguments correctly