Use only valid TERM environment with screen ("screen-256color" might fall back to "vt100")
Bug #900309 reported by
Daniel Hahler
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
byobu |
Won't Fix
|
Low
|
Unassigned | ||
byobu (Ubuntu) |
Expired
|
Low
|
Unassigned |
Bug Description
bin/byobu uses "screen-256color" if the terminal supports 256 colors (like xterm-256color does).
However, if there's no terminfo installed for screen-256color, screen will fallback to vt100, which means no colors and a lot less goodies.
Therefore, before byobu does SCREEN_TERM="-T screen-256color" it should check if that's a valid value, e.g by testing with "TERM=$to_test tput longname 2>/dev/null".
summary: |
- Use only valid TERM environment with screen + Use only valid TERM environment with screen ("screen-256color" might + fall back to "vt100") |
Changed in byobu: | |
status: | Fix Committed → Fix Released |
Changed in byobu: | |
status: | Incomplete → Won't Fix |
To post a comment you must log in.
Hmm, I don't quite understand what situation we're trying to protect against here, that we're not already handling.
What's the actual problem, and how do I reproduce it?
We currently do this:
if [ "$(tput colors 2>/dev/null || echo 0)" = "256" ]; then
SCREEN_ TERM="- T screen-256color"
fi
# Check if our terminfo supports 256 colors
if command -v tput >/dev/null; then
fi
What situations are not handled/detected by that?