regression: eq preferences get lost

[Owen Williams]

Since the fix went in to prevent invalid EQ shelf settings, I've had problems with my eq settings getting reset. Specifically the low shelf gets reset to a very low value near zero. Not only is this incorrect, it causes horrible popping-bass artifacts in playback, like occasional massive bass kicks.

[Owen Williams (ywwg)]

Fixed -- magic values were not removed from freq-to-slider function.

[Owen Williams (ywwg)]

Not sure if this is fixed... my EQ values seem to be creeping downward every time I open mixxx -- most likely rounding errors from conversions to ints

[Owen Williams (ywwg)]

OK I submitted a new patch (r2972) to save the eq values as doubles. The slider is still an integer, but at least now the values don't continuously get rounded down.

Also changed the midpoint text item to reflect the actual value at that point.

[RJ Skerry-Ryan (rryan)]

Nice one -- thanks for following up.

On Tue, Dec 6, 2011 at 2:40 PM, Owen Williams <email address hidden> wrote:

> OK I submitted a new patch (r2972) to save the eq values as doubles.
> The slider is still an integer, but at least now the values don't
> continuously get rounded down.
>
> Also changed the midpoint text item to reflect the actual value at that
> point.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/897521
>
> Title:
> regression: eq preferences get lost
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/897521/+subscriptions
>

[RJ Skerry-Ryan (rryan)]

I think this bug is still lingering. I've had my EQ settings reset a couple of times now and the value they reset to causes very bad feedback issues that make Mixxx just output screeching terrible noises.

[RJ Skerry-Ryan (rryan)]

Oops, I think I know why. Whenever I load up 1.9 my EQ preferences get reset because 1.9 can't deal with the floating point values in mixxx.cfg.

[RJ Skerry-Ryan (rryan)]

OK, since the floating-point EQ change is incompatible with all previous versions of Mixxx I think we need to use a different preference setting for the floating point version.

The logic should go:

Loading EQ preferences:
1) Check for floating point versions
2) If no floating point versions, load integer versions

Saving EQ preferences:
1) Save floating point and integer versions

It's ugly but it'll have to do.

[RJ Skerry-Ryan (rryan)]

btw I'm working on this

[Owen Williams (ywwg)]

I'm happy to work on the fix if it lightens the load. You don't have to fix all the bugs yourself :)

[RJ Skerry-Ryan (rryan)]

Should be fixed now :)

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6149