Requesting removal of source package `gtk-led-askpass' from Ubuntu

[Leo Iannacone]

According to PTS (1), gtk-led-askpass has been removed from Debian testing and unstable.

$ reverse-build-depends --distribution oneiric gtk-led-askpass
Reverse Build-depends in main:
------------------------------

No reverse build-depends found for gtk-led-askpass.

Reverse Build-depends in universe:
---------------------------------

No reverse build-depends found for gtk-led-askpass.

Reverse Build-depends in multiverse:
----------------------------------

No reverse build-depends found for gtk-led-askpass.

Could please remove it from Ubuntu archives?

Thanks.

(1) - http://packages.qa.debian.org/g/gtk-led-askpass.html

_____________________________________________
OLD BUG REPORT:

gtk-led-askpass (0.11-1) unstable; urgency=low

  * New upstream version.
    - Doesn't pass messages as format strings. Closes: #572634.
  * Convert to Debhelper 7.

 -- Dafydd Harries <email address hidden> Wed, 19 Jan 2011 16:23:21 -0500

[Leo Iannacone (l3on)]

gtk-led-askpass (0.11-1ubuntu1) precise; urgency=low

  * Merge from debian unstable (LP: #896902). Remaining changes:
    - debian/rules: add -Wno-error=unused-result to fix FTBFS
    - Makefile.in: fix FTBFS link --as-needed overwriting gtk_led_askpass_LINK

 -- Leo Iannacone <email address hidden> Wed, 06 Jul 2011 19:57:47 +0100

[Evan Broder (broder)]

Leo, it looks like you added the -Wno-error=unused-result from the last version.

Please don't do that. The unused-result warning catches code with insufficient error handling, and insufficient error handling tends to lead to subtle bugs and occasionally security vulnerabilities.

There's a brief write-up on the wiki (https://wiki.ubuntu.com/ToolChain/CompilerFlags#Ignoring_return_code_of_write.28.29) about dealing with warn_unused_result functions. Could you please consult those and see if you can patch the source in a way that causes it to actually handle return values correctly?

(I'm going to go ahead and unsubscribe ubuntu-sponsors for the time being, but feel free to resubscribe at any point)

[Leo Iannacone (l3on)]

Ok, I tried to handle return code from write.

Let's see this debdiff.

gtk-led-askpass (0.11-1ubuntu1) precise; urgency=low

  * Merge from debian unstable (LP: #896902). Remaining changes:
    - Makefile.in: fix FTBFS link --as-needed in gtk_led_askpass_LINK
  * Handling return code of write() in gtk-led-askpass.c

 -- Leo Iannacone <email address hidden> Sun, 04 Dec 2011 18:44:26 +0100

[Leo Iannacone (l3on)]

Please consider to remove '\n' from perror(), I forgot to do that before upload debdiff ...

[Leo Iannacone (l3on)]

Package has been removed from unstable... should we take it anyway ?

[Evan Broder (broder)]

Yes, Ubuntu doesn't generally keep packages that have been removed from Debian. Why don't you turn this bug into a package removal bug? Change the title to indicate that the package should be removed, modify the description to explain why the package should be removed, double-check that the package doesn't have any reverse-dependencies, and then subscribe ubuntu-archive to process it.

(Going to go ahead and unsubscribe sponsors for now, but I'll keep an eye on the bug myself)

[Colin Watson (cjwatson)]

I removed this two months ago as part of a semi-automatic process-removals run, but didn't notice this bug report at the time:

  https://launchpad.net/ubuntu/precise/+source/gtk-led-askpass/0.10-2ubuntu2