Allow to reset the PLAYED counter

[jus]

There is no facility for resetting the numbers how often is track was played already. We should allow to reset the library`s "Played" column to zero for single tracks as for multiple tracks at ones alike.

[akash shetye (shetyeakash)]

I think this feature is important, after say a few sessions these stats stagnate and appear meaningless. I actually ended up playing the same song twice because the playcount was like 16-24 for each track in the library, hard to make out the difference.

[akash shetye (shetyeakash)]

This allows us to reset the played count by right clicking the selected song/s and clicking an option of "Reset Played Count".

[Owen Williams (ywwg)]

Does this patch also work if multiple rows are selected? It looks like it does but I wasn't sure.

[akash shetye (shetyeakash)]

Yes it works for multiple selected tracks as well. :)

[jus (jus)]

Thanks Akash, tested and works like a charm even for multiple selected tracks.

There is one small thing i would recommend to change though - the order of the new "Reset Played Count" entry in the right-click menue. The important track "Properties" option should not be buried in between the options. A simple separator can solve this. See picture (left side).

[akash shetye (shetyeakash)]

Hey jus, that visual was really helpful. Here is an updated patch.

[RJ Skerry-Ryan (rryan)]

Hey Akash,

Are you developing from a branch of the Mixxx source or are you just using the diff command to calculate the diffs between two copies of the mixxx source?

If you used a Bazaar checkout you would be able to generate a diff just by typing "bzr diff" or by using the 'Diff' option in a Bzr GUI tool like TortoiseBzr.

It looks like your patch has lots of diff-related errors in it (e.g. double-quoted sections, those preceded with ++ or +-). Could you try regenerating it using Bazaar?

[akash shetye (shetyeakash)]

I am attaching a patch that was made from lp:mixxx/1.10 but i think it is 1.10.1 since the "sampler exiting patch" was committed to the source. I have used bzr to do the diff and followed the coding guidelines, if anything needs to be improved do tell.

[RJ Skerry-Ryan (rryan)]

Hi Akash,

Your patch looks good except for the indentation. Could you please change your editor to use 4-spaces per indentation level instead of tabs? Make sure to read the Mixxx C++ style guide here: http://mixxx.org/wiki/doku.php/coding_guidelines

Thanks!
RJ

[RJ Skerry-Ryan (rryan)]

Hi Akash,

I'd love to get your patch into Mixxx 1.11 before we release it -- any
chance you could fix up the patch soon?

Thanks,
RJ

On Wed, Mar 21, 2012 at 11:04 PM, RJ Ryan <email address hidden> wrote:

> Hi Akash,
>
> Your patch looks good except for the indentation. Could you please
> change your editor to use 4-spaces per indentation level instead of
> tabs? Make sure to read the Mixxx C++ style guide here:
> http://mixxx.org/wiki/doku.php/coding_guidelines
>
> Thanks!
> RJ
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/893009
>
> Title:
> Allow to reset the PLAYED counter
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/893009/+subscriptions
>

[akash shetye (shetyeakash)]

Hey Ryan,

Very sorry this bug just slipped out of my mind. Here is the patch with the corrected indentation and an edit regarding ending the resetplayed QAction object names with 'Act'. It's good to go. Thanks :)

[RJ Skerry-Ryan (rryan)]

Thanks Akash -- committed to lp:mixxx/1.10 and will be in 1.11.0.

[akash shetye (shetyeakash)]

Thank you for the commit.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6128