auth_token.py middleware calls Keystone twice

Bug #890881 reported by Kevin L. Mitchell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Kevin L. Mitchell

Bug Description

Currently, the auth_token.py middleware makes two separate calls to Keystone: one to verify the token, and another to obtain token-linked information such as username and tenant ID. Both of these calls hit the same URI, though one uses HEAD and the other uses GET. This can easily be simplified to a single call by refactoring _verify_claims() and _expound_claims() into a single method that raises an exception if the claim (auth token) cannot be verified, and otherwise processes the information and returns it in the format currently returned by _expound_claims().

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/1643
Committed: http://github.com/openstack/keystone/commit/316e2bca9f267d08fde2ad52350810da9f121442
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit 316e2bca9f267d08fde2ad52350810da9f121442
Author: Kevin L. Mitchell <email address hidden>
Date: Tue Nov 15 17:43:35 2011 -0600

    Refactor auth_token.py to only call out to Keystone once.

    Fixes bug 890881.

    Change-Id: I096d2c63e8f2c996dc1e5dd7315f57e2303d24cb

Changed in keystone:
status: New → Fix Committed
Dolph Mathews (dolph)
Changed in keystone:
assignee: nobody → Kevin L. Mitchell (klmitch)
importance: Undecided → Low
milestone: none → essex-2
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: essex-2 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.