Please backport hg-git(0.3.1-1) from precise to oneiric

[fqj1994]

hg-git 0.2.6 will cause mercurial ( >= 1.9) crash.
0.3.1-1 fixed this bugs.

see changelog of hg-git for more details.

please backport hg-git to oneric.

[Evan Broder (broder)]

Are you interested in backporting hg-git because it introduces new features, or because it fixes bugs?

We prefer to use the backports process only for introducing features, and not for fixing bugs. Because backports aren't installed by default, it means that not everybody gets access to the bug fix.

For fixing bugs we use the SRU process (Stable Release Updates - https://wiki.ubuntu.com/StableReleaseUpdates). However, because of stability risk, we don't do full version upgrades in SRUs, so we need to have an isolated, minimal patch in order to fix the issues.

Can you pick out the patches required to fix the mercurial incompatibilities, and also provide a description of how to reproduce the crashes? Since it sounds like this could have broad impact for hg-git users, I'm happy to drive the SRU process - regardless of whether or not we continue with the backport - but I don't have any familiarity with hg-git.

If there are actually new features from hg-git 0.3.1 that you would still like to backport, please test that the current version of the package builds, installs, and runs in oneiric. You can test this using the backportpackage scripts in ubuntu-dev-tools to build in a PPA, by running something like

    backportpackage -u ppa:<lp username>/<ppa name> -s precise -d oneiric hg-git

Once you've verified that the package builds, installs, and runs, please change the status of this bug to "Confirmed". In the mean time, I'm going to mark it as "Incomplete" so that the backporters can keep track of which bugs we've dealt with.

[fqj1994 (fqj1994)]

As I'm not very familiar with hg-git either.
Maybe my patch will be a diff between the latest version and the old version.
But you said SRUs don't do full upload.
How can I handle this ?

On 11/16/11, Evan Broder <email address hidden> wrote:
> Are you interested in backporting hg-git because it introduces new
> features, or because it fixes bugs?
>
> We prefer to use the backports process only for introducing features,
> and not for fixing bugs. Because backports aren't installed by default,
> it means that not everybody gets access to the bug fix.
>
> For fixing bugs we use the SRU process (Stable Release Updates -
> https://wiki.ubuntu.com/StableReleaseUpdates). However, because of
> stability risk, we don't do full version upgrades in SRUs, so we need to
> have an isolated, minimal patch in order to fix the issues.
>
> Can you pick out the patches required to fix the mercurial
> incompatibilities, and also provide a description of how to reproduce
> the crashes? Since it sounds like this could have broad impact for hg-
> git users, I'm happy to drive the SRU process - regardless of whether or
> not we continue with the backport - but I don't have any familiarity
> with hg-git.
>
> If there are actually new features from hg-git 0.3.1 that you would
> still like to backport, please test that the current version of the
> package builds, installs, and runs in oneiric. You can test this using
> the backportpackage scripts in ubuntu-dev-tools to build in a PPA, by
> running something like
>
> backportpackage -u ppa:<lp username>/<ppa name> -s precise -d
> oneiric hg-git
>
> Once you've verified that the package builds, installs, and runs, please
> change the status of this bug to "Confirmed". In the mean time, I'm
> going to mark it as "Incomplete" so that the backporters can keep track
> of which bugs we've dealt with.
>
> ** Changed in: oneiric-backports
> Status: New => Incomplete
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/890621
>
> Title:
> Please backport hg-git(0.3.1-1) from precise to oneiric
>
> Status in Oneiric Backports:
> Incomplete
> Status in “hg-git” package in Ubuntu:
> Fix Released
> Status in “hg-git” source package in Oneiric:
> New
>
> Bug description:
> hg-git 0.2.6 will cause mercurial ( >= 1.9) crash.
> 0.3.1-1 fixed this bugs.
>
> see changelog of hg-git for more details.
>
> please backport hg-git to oneric.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/oneiric-backports/+bug/890621/+subscriptions
>

--
Qijiang Fan
College of Computer Science and Technology
Huazhong University of Science and Technology
1037 Luoyu Road, Wuhan, Hubei, China

PGP KEY FINGERPRINT: 9DCA 7C0D 30E3 D78B 2D2B 133D 3983 9DD3 50E4 6156

[Evan Broder (broder)]

On Tue, Nov 15, 2011 at 8:59 PM, Qijiang Fan <email address hidden> wrote:
> As I'm not very familiar with hg-git either.
> Maybe my patch will be a diff between the latest version and the old version.
> But you said SRUs don't do full upload.
> How can I handle this ?

I can probably help identify the patch. However, I don't know what
causes the old version of hg-git to crash - just running "hg git
--help" seems to work.

Can you give me a set of steps to cause hg-git to crash?

[fqj1994 (fqj1994)]

I'm not using Ubuntu. I use Debian.
Maybe you can refer to bug #645037 in debian's BTS.(
http://bugs.debian.org/645037)

On Wed, Nov 16, 2011 at 4:07 PM, Evan Broder <email address hidden> wrote:

> On Tue, Nov 15, 2011 at 8:59 PM, Qijiang Fan <email address hidden> wrote:
> > As I'm not very familiar with hg-git either.
> > Maybe my patch will be a diff between the latest version and the old
> version.
> > But you said SRUs don't do full upload.
> > How can I handle this ?
>
> I can probably help identify the patch. However, I don't know what
> causes the old version of hg-git to crash - just running "hg git
> --help" seems to work.
>
> Can you give me a set of steps to cause hg-git to crash?
>

[Evan Broder (broder)]

"hg outgoing" seems to produce completely bogus information for me,
but I can't seem to make it crash.

evan@caron:~/src$ hg clone git+ssh://<email address hidden>/nelhage/reptyr.git hgtest
importing Hg objects into Git
["git-upload-pack '/nelhage/reptyr.git'"]
Counting objects: 424, done.
Compressing objects: 100% (190/190), done.
Total 424 (delta 252), reused 394 (delta 222)
importing Git objects into Hg
updating to branch default
18 files updated, 0 files merged, 0 files removed, 0 files unresolved
evan@caron:~/src$ cd hgtest
evan@caron:~/src/hgtest$ rm *
rm: cannot remove `arch': Is a directory
evan@caron:~/src/hgtest$ ls
arch
evan@caron:~/src/hgtest$ hg addremove
removing COPYING
removing ChangeLog
removing Makefile
removing NOTES
removing README
removing attach.c
removing ptrace.c
removing ptrace.h
removing reptyr.1
removing reptyr.c
removing reptyr.fr.1
removing reptyr.h
evan@caron:~/src/hgtest$ hg commit -m 'Dummy commit'
evan@caron:~/src/hgtest$ hg out | head
comparing with git+ssh://<email address hidden>/nelhage/reptyr.git
importing Hg objects into Git
["git-receive-pack '/nelhage/reptyr.git'"]
searching for changes
changeset: 0:e2ab176fb90c
user: Nelson Elhage <email address hidden>
date: Tue Jan 11 09:35:37 2011 -0500
summary: Initial import. Mostly able to run barnowl.

changeset: 1:c81253a26a49

[fqj1994 (fqj1994)]

I don't know.
The upstream's git commit log also shows there were problems for 0.2.6 with
mercurial 1.9.

On Thu, Nov 17, 2011 at 4:54 AM, Evan Broder <email address hidden> wrote:

> "hg outgoing" seems to produce completely bogus information for me,
> but I can't seem to make it crash.
>
> evan@caron:~/src$ hg clone git+ssh://<email address hidden>/nelhage/reptyr.githgtest
> importing Hg objects into Git
> ["git-upload-pack '/nelhage/reptyr.git'"]
> Counting objects: 424, done.
> Compressing objects: 100% (190/190), done.
> Total 424 (delta 252), reused 394 (delta 222)
> importing Git objects into Hg
> updating to branch default
> 18 files updated, 0 files merged, 0 files removed, 0 files unresolved
> evan@caron:~/src$ cd hgtest
> evan@caron:~/src/hgtest$ rm *
> rm: cannot remove `arch': Is a directory
> evan@caron:~/src/hgtest$ ls
> arch
> evan@caron:~/src/hgtest$ hg addremove
> removing COPYING
> removing ChangeLog
> removing Makefile
> removing NOTES
> removing README
> removing attach.c
> removing ptrace.c
> removing ptrace.h
> removing reptyr.1
> removing reptyr.c
> removing reptyr.fr.1
> removing reptyr.h
> evan@caron:~/src/hgtest$ hg commit -m 'Dummy commit'
> evan@caron:~/src/hgtest$ hg out | head
> comparing with git+ssh://<email address hidden>/nelhage/reptyr.git
> importing Hg objects into Git
> ["git-receive-pack '/nelhage/reptyr.git'"]
> searching for changes
> changeset: 0:e2ab176fb90c
> user: Nelson Elhage <email address hidden>
> date: Tue Jan 11 09:35:37 2011 -0500
> summary: Initial import. Mostly able to run barnowl.
>
> changeset: 1:c81253a26a49
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/890621
>
> Title:
> Please backport hg-git(0.3.1-1) from precise to oneiric
>
> Status in Oneiric Backports:
> Incomplete
> Status in “hg-git” package in Ubuntu:
> Fix Released
> Status in “hg-git” source package in Oneiric:
> New
>
> Bug description:
> hg-git 0.2.6 will cause mercurial ( >= 1.9) crash.
> 0.3.1-1 fixed this bugs.
>
> see changelog of hg-git for more details.
>
> please backport hg-git to oneric.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/oneiric-backports/+bug/890621/+subscriptions
>

[Evan Broder (broder)]

I've e-mailed the reporter of the Debian bug to try and get some more information about what the problem was. I'll follow up on this bug if we can figure out.

Qijiang, do I understand correctly that your primary purpose opening this bug was to make sure that Oneiric users had a functional hg-git package? If that's the case, we're unfortunately a little stuck. Fixing a package isn't generally valid justification for a backport, but we can't move the SRU forward without a better understanding of the bug.

Assuming I'm understanding your motivations correctly, I'd like to close the backport bug, and mark the SRU bug as "Incomplete" until we can get a better handle on what the actual bug is, if that's OK with you.

Thanks again for your feedback and responsiveness.

[fqj1994 (fqj1994)]

I cannot find a way to generate the minimal patches.
I've tried install Ubuntu on my VMs. I fount -backports is enabled by default.
Can you backports it?

[Evan Broder (broder)]

Backports are enabled by default, but we set NotAutomatic: yes, the same way that backports are on Debian, so backporting a package does not benefit all users for bug fixes.

[Evan Broder (broder)]

I got an e-mail back from the person who filed the Debian bug.

Apparently enabling the hggit extension, hg clone'ing a git repository, and running hg outgoing was enough to reproduce the crash, and I don't see that on Oneiric.

However, he was testing with mercurial=1.9.2-1, and Oneiric only has 1.9.1-1ubuntu0.1, so it's possible that there was some sort of skew in the point release.

I'm going to go ahead and close out this bug, since it doesn't seem like there is actually an issue in Ubuntu.